From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f180.google.com ([209.85.220.180]:32906 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932954AbcCQOp0 (ORCPT ); Thu, 17 Mar 2016 10:45:26 -0400 Date: Thu, 17 Mar 2016 10:46:19 -0400 From: Johan Hovold To: Oliver Neukum Cc: linux-usb@vger.kernel.org, johan@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] cypress_m8: add sanity checking Message-ID: <20160317144619.GA2018@localhost> References: <1458209251-15366-1-git-send-email-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458209251-15366-1-git-send-email-oneukum@suse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Mar 17, 2016 at 11:07:31AM +0100, Oliver Neukum wrote: > An attack using missing endpoints exists. > CVE-2016-3137 > > Signed-off-by: Oliver Neukum > CC: stable@vger.kernel.org > --- > drivers/usb/serial/cypress_m8.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c > index 01bf533..8eeff72 100644 > --- a/drivers/usb/serial/cypress_m8.c > +++ b/drivers/usb/serial/cypress_m8.c > @@ -447,6 +447,12 @@ static int cypress_generic_port_probe(struct usb_serial_port *port) > struct usb_serial *serial = port->serial; > struct cypress_private *priv; > > + if (!port->interrupt_out_urb || !port->interrupt_in_urb) { > + dev_err(&port->dev, > + "cypress_m8 is missing a required endpoint"); Trailing '\n' missing. No need to include the driver name here, it will be added by dev_err. Also please include a patch revision in the summary when resending (and a changelog below the cut-off line). Thanks, Johan