All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: shaohui ??? <shh.xie@gmail.com>, netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Shaohui Xie <Shaohui.Xie@freescale.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"N, Mugunthan V" <mugunthanvnm@ti.com>,
	drivshin@allworx.com
Subject: Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine
Date: Thu, 17 Mar 2016 16:12:40 +0100	[thread overview]
Message-ID: <20160317151240.GD26019@lunn.ch> (raw)
In-Reply-To: <CAGm1_kvJn0Pq38iqOmOcyNpe62EEUmq_s5G2_HXps4Gx+xB_=Q@mail.gmail.com>

> After changing cpsw_emac0 entry to:
> 
> &cpsw_emac0 {
>         phy-mode = "rmii";
>         dual_emac_res_vlan = <1>;
>         fixed-link {
>                 speed = <100>;
>                 full-duplex;
>         };
> };
> 
> I've got packets running in both directions.

Great.
 
> Now I have another problem: I cannot disable ICPlus IP175D ports via
> SIOCSMIIREG as I could do previously. I get not ioctl errors [1], but
> the ports are always on.
> 
> [1] https://github.com/visionsystemsgmbh/libonrisc/blob/master/src/onrisc.c#L83

The MDIO bus is now logically not connected to eth0. Instead you have
the fixed-link mdio device connected to eth0. So SIOCSMIIREG calls on
eth0 now try to manipulate the fixed link phys.

However, i think you can still access the MDIO bus, just use eth1 in
your ioctl call.

You should however consider writing a DSA driver for the switch.

    Andrew

  reply	other threads:[~2016-03-17 15:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  4:23 [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine shh.xie
2015-08-14 17:01 ` Florian Fainelli
2015-08-17  7:29   ` Shaohui Xie
2015-08-17  7:48   ` Shaohui Xie
2015-08-17 19:18 ` David Miller
2015-08-24  5:35   ` Andy Fleming
2016-03-16 15:59 ` Yegor Yefremov
2016-03-16 16:18   ` Andrew Lunn
2016-03-16 22:23     ` Yegor Yefremov
2016-03-16 23:05       ` Andrew Lunn
2016-03-17  8:14         ` Yegor Yefremov
2016-03-17 13:41           ` Andrew Lunn
2016-03-17 14:50             ` Yegor Yefremov
2016-03-17 15:12               ` Andrew Lunn [this message]
2016-03-17 15:21                 ` Yegor Yefremov
2016-03-17 15:28                   ` Andrew Lunn
2016-03-17 15:33                     ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317151240.GD26019@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Shaohui.Xie@freescale.com \
    --cc=davem@davemloft.net \
    --cc=drivshin@allworx.com \
    --cc=f.fainelli@gmail.com \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=shh.xie@gmail.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.