From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests/shell: unload modules between tests
Date: Thu, 17 Mar 2016 16:42:51 +0100 [thread overview]
Message-ID: <20160317154251.GA5866@salvia> (raw)
In-Reply-To: <145820368731.17259.3174729391842967272.stgit@r2d2.cica.es>
On Thu, Mar 17, 2016 at 09:34:47AM +0100, Arturo Borrero Gonzalez wrote:
> This patch adjusts the main test script so it unload all nftables
> kernel modules between tests.
>
> This way we achieve two interesting things:
> * avoid false errors in some testcases due to module loading order
> * the module loading/unloading path itself
>
> The false positives is for example, listing ruleset per families, which depends
> on the loading order of nf_tables_xx modules.
>
> We can later add more modules to unload incrementally (for
> example nf_tables_switchdev).
>
> This patch assumes we are working with a kernel which is compiled with
> nf_tables =m, the case using =y is not supported and can still produce false
> positives in some testcases due to module ordering.
Applied, thanks Arturo.
next prev parent reply other threads:[~2016-03-17 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 8:34 [nft PATCH] tests/shell: unload modules between tests Arturo Borrero Gonzalez
2016-03-17 15:42 ` Pablo Neira Ayuso [this message]
2016-03-17 18:02 ` Piyush Pangtey
2016-03-18 8:41 ` Arturo Borrero Gonzalez
2016-03-22 19:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317154251.GA5866@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.