From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Date: Thu, 17 Mar 2016 15:05:23 -0300 Message-ID: <20160317180523.GA2619@joana> References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1458236486.9556.11.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Joe Perches Cc: devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , David Airlie , Gustavo Padovan , Maarten Lankhorst , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Greg Hackmann , Greg Kroah-Hartman , Riley Andrews , Daniel Vetter , akpm@linux-foundation.org, John Harrison List-Id: dri-devel@lists.freedesktop.org 2016-03-17 Joe Perches : > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > > This function had copies in 3 different files. Unify them in > > kernel.h. > = > This is only used by gpu/drm. > = > I think this is a poor name for a generic function > that would be in kernel.h. > = > Isn't there an include file in linux/drm that's > appropriate for this. =A0Maybe drmP.h > = > Maybe prefix this function name with drm_ too. No, the next patch adds a user to drivers/staging (which will be moved to drivers/dma-buf) soon. Maybe move to a different header in include/linux/? not sure which one. > Also, there's this that might conflict: > = > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0ptr_to_compat(p) > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0((unsigned long)(p)) Right, I'll figure out how to replace these two too. Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935912AbcCQSFg (ORCPT ); Thu, 17 Mar 2016 14:05:36 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:51165 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932829AbcCQSFd convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 14:05:33 -0400 Date: Thu, 17 Mar 2016 15:05:23 -0300 From: Gustavo Padovan To: Joe Perches Cc: Gustavo Padovan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , akpm@linux-foundation.org, David Airlie , Daniel Vetter Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Message-ID: <20160317180523.GA2619@joana> References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1458236486.9556.11.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-03-17 Joe Perches : > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > > This function had copies in 3 different files. Unify them in > > kernel.h. > > This is only used by gpu/drm. > > I think this is a poor name for a generic function > that would be in kernel.h. > > Isn't there an include file in linux/drm that's > appropriate for this.  Maybe drmP.h > > Maybe prefix this function name with drm_ too. No, the next patch adds a user to drivers/staging (which will be moved to drivers/dma-buf) soon. Maybe move to a different header in include/linux/? not sure which one. > Also, there's this that might conflict: > > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ptr_to_compat(p) > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ((unsigned long)(p)) Right, I'll figure out how to replace these two too. Gustavo