From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: bcm283x: don't always define CONFIG_BCM2835
Date: Thu, 17 Mar 2016 14:08:35 -0400 [thread overview]
Message-ID: <20160317180835.GD23166@bill-the-cat> (raw)
In-Reply-To: <56EAEAEB.4040808@wwwdotorg.org>
On Thu, Mar 17, 2016 at 11:35:39AM -0600, Stephen Warren wrote:
> On 03/17/2016 09:54 AM, Tom Rini wrote:
> >On Wed, Mar 16, 2016 at 09:40:56PM -0600, Stephen Warren wrote:
> >
> >>Currently, CONFIG_BCM2835 is defined for all BCM283x builds and _BCM2836
> >>is defined when building for that SoC. That means there isn't a single
> >>define that means "exactly BCM2835". This will complicate future patches
> >>where BCM2835-vs-anything-else needs to be determined simply.
> >>
> >>Modify the code to define one or the other of CONFIG_BCM2835/BCM2836 so
> >>future patches are simpler.
> >>
> >>Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> >[snip]
> >>diff --git a/include/configs/rpi.h b/include/configs/rpi.h
> >>index 86422e390da2..a788ce42e44c 100644
> >>--- a/include/configs/rpi.h
> >>+++ b/include/configs/rpi.h
> >>@@ -7,6 +7,7 @@
> >> #ifndef __CONFIG_H
> >> #define __CONFIG_H
> >>
> >>+#define CONFIG_BCM2835
> >> #define CONFIG_SYS_CACHELINE_SIZE 32
> >>
> >> #include "rpi-common.h"
> >
> >Shouldn't we take this as the time to move it to
> >arch/arm/mach-bcm283x/Kconfig ?
>
> It is probably time yes, although I'd rather do that in a separate
> patch either way. I should be able to work that patch up before
> sending the actual RPi3 board file patches.
OK:
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160317/d811fc30/attachment.sig>
next prev parent reply other threads:[~2016-03-17 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 3:40 [U-Boot] [PATCH 1/2] ARM: bcm283x: don't always define CONFIG_BCM2835 Stephen Warren
2016-03-17 3:40 ` [U-Boot] [PATCH 2/2] ARM: bcm2835: fix 64-bit build warning in mbox Stephen Warren
2016-03-17 15:54 ` Tom Rini
2016-03-27 22:25 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-17 15:54 ` [U-Boot] [PATCH 1/2] ARM: bcm283x: don't always define CONFIG_BCM2835 Tom Rini
2016-03-17 17:35 ` Stephen Warren
2016-03-17 18:08 ` Tom Rini [this message]
2016-03-27 22:25 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317180835.GD23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.