From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Date: Thu, 17 Mar 2016 15:43:18 -0300 Message-ID: <20160317184318.GA2611@joana> References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2DDA6E337 for ; Thu, 17 Mar 2016 18:43:25 +0000 (UTC) Received: by mail-yw0-f193.google.com with SMTP id p65so7619954ywb.3 for ; Thu, 17 Mar 2016 11:43:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160317180523.GA2619@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Joe Perches , Daniel Vetter , akpm@linux-foundation.org, John Harrison List-Id: dri-devel@lists.freedesktop.org MjAxNi0wMy0xNyBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28u dWs+OgoKPiAyMDE2LTAzLTE3IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+Ogo+IAo+ID4g T24gVGh1LCAyMDE2LTAzLTE3IGF0IDE0OjMwIC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6 Cj4gPiA+IFRoaXMgZnVuY3Rpb24gaGFkIGNvcGllcyBpbiAzIGRpZmZlcmVudCBmaWxlcy4gVW5p ZnkgdGhlbSBpbgo+ID4gPiBrZXJuZWwuaC4KPiA+IAo+ID4gVGhpcyBpcyBvbmx5IHVzZWQgYnkg Z3B1L2RybS4KPiA+IAo+ID4gSSB0aGluayB0aGlzIGlzIGEgcG9vciBuYW1lIGZvciBhIGdlbmVy aWMgZnVuY3Rpb24KPiA+IHRoYXQgd291bGQgYmUgaW4ga2VybmVsLmguCj4gPiAKPiA+IElzbid0 IHRoZXJlIGFuIGluY2x1ZGUgZmlsZSBpbiBsaW51eC9kcm0gdGhhdCdzCj4gPiBhcHByb3ByaWF0 ZSBmb3IgdGhpcy4gwqBNYXliZSBkcm1QLmgKPiA+IAo+ID4gTWF5YmUgcHJlZml4IHRoaXMgZnVu Y3Rpb24gbmFtZSB3aXRoIGRybV8gdG9vLgo+IAo+IE5vLCB0aGUgbmV4dCBwYXRjaCBhZGRzIGEg dXNlciB0byBkcml2ZXJzL3N0YWdpbmcgKHdoaWNoIHdpbGwgYmUgbW92ZWQKPiB0byBkcml2ZXJz L2RtYS1idWYpIHNvb24uIE1heWJlIG1vdmUgdG8gYSBkaWZmZXJlbnQgaGVhZGVyIGluCj4gaW5j bHVkZS9saW51eC8/IG5vdCBzdXJlIHdoaWNoIG9uZS4KPiAKPiA+IEFsc28sIHRoZXJlJ3MgdGhp cyB0aGF0IG1pZ2h0IGNvbmZsaWN0Ogo+ID4gCj4gPiBhcmNoL3Bvd2VycGMva2VybmVsL3NpZ25h bF8zMi5jOiNkZWZpbmUgdG9fdXNlcl9wdHIocCnCoMKgwqDCoMKgwqDCoMKgwqDCoHB0cl90b19j b21wYXQocCkKPiA+IGFyY2gvcG93ZXJwYy9rZXJuZWwvc2lnbmFsXzMyLmM6I2RlZmluZSB0b191 c2VyX3B0cihwKcKgwqDCoMKgwqDCoMKgwqDCoMKgKCh1bnNpZ25lZCBsb25nKShwKSkKPiAKPiBS aWdodCwgSSdsbCBmaWd1cmUgb3V0IGhvdyB0byByZXBsYWNlIHRoZXNlIHR3byB0b28uCgpUaGUg cG93ZXJwYyB0b191c2VyX3B0ciBoYXMgYSBkaWZmZXJlbnQgbWVhbmluZyBmcm9tIHRoZSBvbmUg SSdtIGFkZGluZwppbiB0aGlzIHBhdGNoLiBJIHByb3Bvc2Ugd2UganVzdCByZW5hbWUgcG93ZXJw YydzIHRvX3VzZXJfcHRyIHRvCl9fdG9fdXNlcl9wdHIgYW5kIGxlYXZlIHRoZSByZXN0IGFzIGlz LgoKCUd1c3Rhdm8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756448AbcCQSn0 (ORCPT ); Thu, 17 Mar 2016 14:43:26 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:33090 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbcCQSnZ convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 14:43:25 -0400 Date: Thu, 17 Mar 2016 15:43:18 -0300 From: Gustavo Padovan To: Gustavo Padovan Cc: Joe Perches , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , akpm@linux-foundation.org, David Airlie , Daniel Vetter Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Message-ID: <20160317184318.GA2611@joana> Mail-Followup-To: Gustavo Padovan , Gustavo Padovan , Joe Perches , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , akpm@linux-foundation.org, David Airlie , Daniel Vetter References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20160317180523.GA2619@joana> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-03-17 Gustavo Padovan : > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > > > This function had copies in 3 different files. Unify them in > > > kernel.h. > > > > This is only used by gpu/drm. > > > > I think this is a poor name for a generic function > > that would be in kernel.h. > > > > Isn't there an include file in linux/drm that's > > appropriate for this.  Maybe drmP.h > > > > Maybe prefix this function name with drm_ too. > > No, the next patch adds a user to drivers/staging (which will be moved > to drivers/dma-buf) soon. Maybe move to a different header in > include/linux/? not sure which one. > > > Also, there's this that might conflict: > > > > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ptr_to_compat(p) > > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ((unsigned long)(p)) > > Right, I'll figure out how to replace these two too. The powerpc to_user_ptr has a different meaning from the one I'm adding in this patch. I propose we just rename powerpc's to_user_ptr to __to_user_ptr and leave the rest as is. Gustavo