From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qR2km28xczDq5s for ; Fri, 18 Mar 2016 09:16:31 +1100 (AEDT) Received: by mail-yw0-f195.google.com with SMTP id p65so8195400ywb.3 for ; Thu, 17 Mar 2016 15:16:31 -0700 (PDT) Date: Thu, 17 Mar 2016 19:16:19 -0300 From: Gustavo Padovan To: Joe Perches Cc: Rob Clark , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Linux Kernel Mailing List , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Andrew Morton , David Airlie , Daniel Vetter , linuxppc-dev Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Message-ID: <20160317221619.GA11578@joana> References: <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> <1458246150.9556.17.camel@perches.com> <1458247207.9556.28.camel@perches.com> <1458249003.9556.30.camel@perches.com> <20160317211910.GB2611@joana> <1458250430.9556.39.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1458250430.9556.39.camel@perches.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , 2016-03-17 Joe Perches : > On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote: > > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote: > > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrot= e: > > > [] > > > > > It's a name that seems like it should be a straightforward > > > > > cast of a kernel pointer to a __user pointer like: > > > > >=20 > > > > > static inline void __user *to_user_ptr(void *p) > > > > > { > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return (void __us= er *)p; > > > > > } > > > > ahh, ok.=C2=A0=C2=A0I guess I was used to using it in the context o= f ioctl > > > > structs..=C2=A0=C2=A0in that context u64 -> (void __user *) made mo= re sense. > > > >=20 > > > > Maybe uapi_to_ptr()?=C2=A0=C2=A0(ok, not super-creative.. maybe som= eone has a > > > > better idea) > > > Maybe u64_to_user_ptr? > > That is a good name. If everyone agrees I can resend this patch > > changing it to u64_to_user_ptr. Then should we still keep it on > > kernel.h? >=20 > I've no particular opinion about location, > but maybe compat.h might be appropriate. I don't think this is really related to compat. I'd keep kernel.h. The problem I'm trying to solve here is: CC drivers/dma-buf/sync_file.o drivers/dma-buf/sync_file.c: In function =E2=80=98sync_file_ioctl_fence_inf= o=E2=80=99: drivers/dma-buf/sync_file.c:341:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] if (copy_to_user((void __user *)info.sync_fence_info, fence_info, where info.sync_fence_info is __u64. Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Date: Thu, 17 Mar 2016 19:16:19 -0300 Message-ID: <20160317221619.GA11578@joana> References: <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> <1458246150.9556.17.camel@perches.com> <1458247207.9556.28.camel@perches.com> <1458249003.9556.30.camel@perches.com> <20160317211910.GB2611@joana> <1458250430.9556.39.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1458250430.9556.39.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Joe Perches Cc: devel@driverdev.osuosl.org, linuxppc-dev , Daniel Stone , David Airlie , Benjamin Herrenschmidt , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Maarten Lankhorst , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Daniel Vetter , Rob Clark , Greg Hackmann , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Riley Andrews , Daniel Vetter , Andrew Morton , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org MjAxNi0wMy0xNyBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPjoKCj4gT24gVGh1LCAyMDE2 LTAzLTE3IGF0IDE4OjE5IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6Cj4gPiAyMDE2LTAz LTE3IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+Ogo+ID4gPiBPbiBUaHUsIDIwMTYtMDMt MTcgYXQgMTY6NTAgLTA0MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIE1hciAx NywgMjAxNiBhdCA0OjQwIFBNLCBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPiB3cm90ZToK PiA+ID4gW10KPiA+ID4gPiA+IEl0J3MgYSBuYW1lIHRoYXQgc2VlbXMgbGlrZSBpdCBzaG91bGQg YmUgYSBzdHJhaWdodGZvcndhcmQKPiA+ID4gPiA+IGNhc3Qgb2YgYSBrZXJuZWwgcG9pbnRlciB0 byBhIF9fdXNlciBwb2ludGVyIGxpa2U6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IHN0YXRpYyBpbmxp bmUgdm9pZCBfX3VzZXIgKnRvX3VzZXJfcHRyKHZvaWQgKnApCj4gPiA+ID4gPiB7Cj4gPiA+ID4g PiDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuICh2b2lkIF9fdXNlciAqKXA7Cj4gPiA+ID4gPiB9Cj4g PiA+ID4gYWhoLCBvay7CoMKgSSBndWVzcyBJIHdhcyB1c2VkIHRvIHVzaW5nIGl0IGluIHRoZSBj b250ZXh0IG9mIGlvY3RsCj4gPiA+ID4gc3RydWN0cy4uwqDCoGluIHRoYXQgY29udGV4dCB1NjQg LT4gKHZvaWQgX191c2VyICopIG1hZGUgbW9yZSBzZW5zZS4KPiA+ID4gPiAKPiA+ID4gPiBNYXli ZSB1YXBpX3RvX3B0cigpP8KgwqAob2ssIG5vdCBzdXBlci1jcmVhdGl2ZS4uIG1heWJlIHNvbWVv bmUgaGFzIGEKPiA+ID4gPiBiZXR0ZXIgaWRlYSkKPiA+ID4gTWF5YmUgdTY0X3RvX3VzZXJfcHRy Pwo+ID4gVGhhdCBpcyBhIGdvb2QgbmFtZS4gSWYgZXZlcnlvbmUgYWdyZWVzIEkgY2FuIHJlc2Vu ZCB0aGlzIHBhdGNoCj4gPiBjaGFuZ2luZyBpdCB0byB1NjRfdG9fdXNlcl9wdHIuIFRoZW4gc2hv dWxkIHdlIHN0aWxsIGtlZXAgaXQgb24KPiA+IGtlcm5lbC5oPwo+IAo+IEkndmUgbm8gcGFydGlj dWxhciBvcGluaW9uIGFib3V0IGxvY2F0aW9uLAo+IGJ1dCBtYXliZSBjb21wYXQuaCBtaWdodCBi ZSBhcHByb3ByaWF0ZS4KCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyByZWFsbHkgcmVsYXRlZCB0byBj b21wYXQuIEknZCBrZWVwIGtlcm5lbC5oLgoKVGhlIHByb2JsZW0gSSdtIHRyeWluZyB0byBzb2x2 ZSBoZXJlIGlzOgoKQ0MgICAgICBkcml2ZXJzL2RtYS1idWYvc3luY19maWxlLm8KZHJpdmVycy9k bWEtYnVmL3N5bmNfZmlsZS5jOiBJbiBmdW5jdGlvbiDigJhzeW5jX2ZpbGVfaW9jdGxfZmVuY2Vf aW5mb+KAmToKZHJpdmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jOjM0MToxOTogd2FybmluZzogY2Fz dCB0byBwb2ludGVyIGZyb20KaW50ZWdlciBvZiBkaWZmZXJlbnQgc2l6ZSBbLVdpbnQtdG8tcG9p bnRlci1jYXN0XQogIGlmIChjb3B5X3RvX3VzZXIoKHZvaWQgX191c2VyICopaW5mby5zeW5jX2Zl bmNlX2luZm8sIGZlbmNlX2luZm8sCgp3aGVyZSBpbmZvLnN5bmNfZmVuY2VfaW5mbyBpcyBfX3U2 NC4KCglHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6 Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZl cmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756612AbcCQWQj (ORCPT ); Thu, 17 Mar 2016 18:16:39 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36460 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbcCQWQa convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 18:16:30 -0400 Date: Thu, 17 Mar 2016 19:16:19 -0300 From: Gustavo Padovan To: Joe Perches Cc: Rob Clark , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Linux Kernel Mailing List , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Andrew Morton , David Airlie , Daniel Vetter , linuxppc-dev Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Message-ID: <20160317221619.GA11578@joana> Mail-Followup-To: Gustavo Padovan , Joe Perches , Rob Clark , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Linux Kernel Mailing List , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Andrew Morton , David Airlie , Daniel Vetter , linuxppc-dev References: <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> <1458246150.9556.17.camel@perches.com> <1458247207.9556.28.camel@perches.com> <1458249003.9556.30.camel@perches.com> <20160317211910.GB2611@joana> <1458250430.9556.39.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1458250430.9556.39.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-03-17 Joe Perches : > On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote: > > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote: > > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote: > > > [] > > > > > It's a name that seems like it should be a straightforward > > > > > cast of a kernel pointer to a __user pointer like: > > > > > > > > > > static inline void __user *to_user_ptr(void *p) > > > > > { > > > > >         return (void __user *)p; > > > > > } > > > > ahh, ok.  I guess I was used to using it in the context of ioctl > > > > structs..  in that context u64 -> (void __user *) made more sense. > > > > > > > > Maybe uapi_to_ptr()?  (ok, not super-creative.. maybe someone has a > > > > better idea) > > > Maybe u64_to_user_ptr? > > That is a good name. If everyone agrees I can resend this patch > > changing it to u64_to_user_ptr. Then should we still keep it on > > kernel.h? > > I've no particular opinion about location, > but maybe compat.h might be appropriate. I don't think this is really related to compat. I'd keep kernel.h. The problem I'm trying to solve here is: CC drivers/dma-buf/sync_file.o drivers/dma-buf/sync_file.c: In function ‘sync_file_ioctl_fence_info’: drivers/dma-buf/sync_file.c:341:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] if (copy_to_user((void __user *)info.sync_fence_info, fence_info, where info.sync_fence_info is __u64. Gustavo