From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kvalo@codeaurora.org, devel@driverdev.osuosl.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/9] rtlwifi: rtl8723ae: Fix Smatch warning
Date: Fri, 18 Mar 2016 12:03:35 +0300 [thread overview]
Message-ID: <20160318090335.GC30221@mwanda> (raw)
In-Reply-To: <1458240064-31422-8-git-send-email-Larry.Finger@lwfinger.net>
On Thu, Mar 17, 2016 at 01:41:02PM -0500, Larry Finger wrote:
> Smatch reports the following:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c:137 rtl8723e_dm_bt_need_to_dec_bt_pwr() warn: inconsistent indenting
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> index 00a0531..44de695 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> @@ -134,9 +134,9 @@ static bool rtl8723e_dm_bt_need_to_dec_bt_pwr(struct ieee80211_hw *hw)
> if (mgnt_link_status_query(hw) == RT_MEDIA_CONNECT) {
> RT_TRACE(rtlpriv, COMP_BT_COEXIST, DBG_DMESG,
> "Need to decrease bt power\n");
> - rtlpriv->btcoexist.cstate |=
> - BT_COEX_STATE_DEC_BT_POWER;
> - return true;
> + rtlpriv->btcoexist.cstate |=
> + BT_COEX_STATE_DEC_BT_POWER;
Now that we have removed the tab, this can fit on one line.
regards,
dan carpenter
next prev parent reply other threads:[~2016-03-18 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 18:40 [PATCH 0/9] Fix Smatch warnings in rtlwifi family of drivers Larry Finger
2016-03-17 18:40 ` [PATCH 1/9] rtlwifi: Fix Smatch warnings Larry Finger
2016-04-06 18:37 ` [1/9] " Kalle Valo
2016-03-17 18:40 ` [PATCH 2/9] rtlwifi: btcoexist: Fix Smatch warning Larry Finger
2016-03-17 18:40 ` [PATCH 3/9] rtlwifi: rtl8188ee: Fix Smatch warnings Larry Finger
2016-03-17 18:40 ` [PATCH 4/9] rtlwifi: rtl8192c-common: Fix Smatch warning Larry Finger
2016-03-17 18:41 ` [PATCH 5/9] rtlwifi: rtl8192ee: " Larry Finger
2016-03-17 18:41 ` [PATCH 6/9] rtlwifi: rtl8192se: " Larry Finger
2016-03-17 18:41 ` [PATCH 7/9] rtlwifi: rtl8723ae: " Larry Finger
2016-03-18 9:03 ` Dan Carpenter [this message]
2016-03-17 18:41 ` [PATCH 8/9] rtlwifi: rtl8723be: Fix Smatch warnings Larry Finger
2016-03-17 18:41 ` [PATCH 9/9] rtlwifi: rtl8821ae: " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318090335.GC30221@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.