From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 3/6] drm/i915: abstract get config for cpu transcoder Date: Fri, 18 Mar 2016 17:31:16 +0200 Message-ID: <20160318153116.GJ4329@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id C55116E3FD for ; Fri, 18 Mar 2016 15:31:32 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Deepak M , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMTgsIDIwMTYgYXQgMDU6MDU6NDFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTWFrZXMgaXQgbmVhdGVyIHRvIGFkZCB0aGUgc2FtZSBmb3IgRFNJIHRyYW5zY29kZXIu IE5vIGZ1bmN0aW9uYWwKPiBjaGFuZ2VzLgo+IAo+IHYyOiByZW5hbWUgdG8gaHN3X2dldF90cmFu c2NvZGVyX3N0YXRlIGFuZCBhZGQgYSBjb21tZW50IGFib3V0IGdyYWJiaW5nCj4gICAgIHBvd2Vy IHJlZmVyZW5jZSAoVmlsbGUpCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIHwgODcgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZWVjZTUwZWQzZWE2Li45OGQ4 YjU2M2I5YTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTk5 MTAsNiArOTkxMCw1MyBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2dldF9kZGlfcGxsKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXBpcGVfY29uZmlnLT5zaGFyZWRfZHBsbCA9 IGludGVsX2dldF9zaGFyZWRfZHBsbF9ieV9pZChkZXZfcHJpdiwgaWQpOwo+ICB9Cj4gIAo+ICtz dGF0aWMgYm9vbCBoc3dfZ2V0X3RyYW5zY29kZXJfc3RhdGUoc3RydWN0IGludGVsX2NydGMgKmNy dGMsCj4gKwkJCQkgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAr CQkJCSAgICAgdW5zaWduZWQgbG9uZyAqcG93ZXJfZG9tYWluX21hc2spCj4gK3sKPiArCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwllbnVtIGludGVsX2Rpc3Bs YXlfcG93ZXJfZG9tYWluIHBvd2VyX2RvbWFpbjsKPiArCXUzMiB0bXA7Cj4gKwo+ICsJcGlwZV9j b25maWctPmNwdV90cmFuc2NvZGVyID0gKGVudW0gdHJhbnNjb2RlcikgY3J0Yy0+cGlwZTsKPiAr Cj4gKwkvKgo+ICsJICogWFhYOiBEbyBpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFibGVk IGJlZm9yZSByZWFkaW5nIHRoaXMgKGZvcgo+ICsJICogY29uc2lzdGVuY3kgYW5kIGxlc3Mgc3Vy cHJpc2luZyBjb2RlOyBpdCdzIGluIGFsd2F5cyBvbiBwb3dlcikuCj4gKwkgKi8KPiArCXRtcCA9 IEk5MTVfUkVBRChUUkFOU19ERElfRlVOQ19DVEwoVFJBTlNDT0RFUl9FRFApKTsKPiArCWlmICh0 bXAgJiBUUkFOU19ERElfRlVOQ19FTkFCTEUpIHsKPiArCQllbnVtIHBpcGUgdHJhbnNfZWRwX3Bp cGU7Cj4gKwkJc3dpdGNoICh0bXAgJiBUUkFOU19ERElfRURQX0lOUFVUX01BU0spIHsKPiArCQlk ZWZhdWx0Ogo+ICsJCQlXQVJOKDEsICJ1bmtub3duIHBpcGUgbGlua2VkIHRvIGVkcCB0cmFuc2Nv ZGVyXG4iKTsKPiArCQljYXNlIFRSQU5TX0RESV9FRFBfSU5QVVRfQV9PTk9GRjoKPiArCQljYXNl IFRSQU5TX0RESV9FRFBfSU5QVVRfQV9PTjoKPiArCQkJdHJhbnNfZWRwX3BpcGUgPSBQSVBFX0E7 Cj4gKwkJCWJyZWFrOwo+ICsJCWNhc2UgVFJBTlNfRERJX0VEUF9JTlBVVF9CX09OT0ZGOgo+ICsJ CQl0cmFuc19lZHBfcGlwZSA9IFBJUEVfQjsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSBUUkFOU19E RElfRURQX0lOUFVUX0NfT05PRkY6Cj4gKwkJCXRyYW5zX2VkcF9waXBlID0gUElQRV9DOwo+ICsJ CQlicmVhazsKPiArCQl9Cj4gKwo+ICsJCWlmICh0cmFuc19lZHBfcGlwZSA9PSBjcnRjLT5waXBl KQo+ICsJCQlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgPSBUUkFOU0NPREVSX0VEUDsKPiAr CX0KPiArCj4gKwlwb3dlcl9kb21haW4gPSBQT1dFUl9ET01BSU5fVFJBTlNDT0RFUihwaXBlX2Nv bmZpZy0+Y3B1X3RyYW5zY29kZXIpOwo+ICsJaWYgKCFpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9p Zl9lbmFibGVkKGRldl9wcml2LCBwb3dlcl9kb21haW4pKQo+ICsJCXJldHVybiBmYWxzZTsKPiAr CSpwb3dlcl9kb21haW5fbWFzayB8PSBCSVQocG93ZXJfZG9tYWluKTsKPiArCj4gKwl0bXAgPSBJ OTE1X1JFQUQoUElQRUNPTkYocGlwZV9jb25maWctPmNwdV90cmFuc2NvZGVyKSk7Cj4gKwo+ICsJ cmV0dXJuIHRtcCAmIFBJUEVDT05GX0VOQUJMRTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaGFz d2VsbF9nZXRfZGRpX3BvcnRfc3RhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJCQkg ICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ICB7Cj4gQEAgLTk5 NjAsNDggKzEwMDA3LDE4IEBAIHN0YXRpYyBib29sIGhhc3dlbGxfZ2V0X3BpcGVfY29uZmlnKHN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21h aW4gcG93ZXJfZG9tYWluOwo+ICAJdW5zaWduZWQgbG9uZyBwb3dlcl9kb21haW5fbWFzazsKPiAt CXVpbnQzMl90IHRtcDsKPiAtCWJvb2wgcmV0Owo+ICsJYm9vbCBhY3RpdmU7Cj4gIAo+ICAJcG93 ZXJfZG9tYWluID0gUE9XRVJfRE9NQUlOX1BJUEUoY3J0Yy0+cGlwZSk7Cj4gIAlpZiAoIWludGVs X2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbikpCj4g IAkJcmV0dXJuIGZhbHNlOwo+ICAJcG93ZXJfZG9tYWluX21hc2sgPSBCSVQocG93ZXJfZG9tYWlu KTsKPiAgCj4gLQlyZXQgPSBmYWxzZTsKPiAtCj4gLQlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29k ZXIgPSAoZW51bSB0cmFuc2NvZGVyKSBjcnRjLT5waXBlOwo+ICAJcGlwZV9jb25maWctPnNoYXJl ZF9kcGxsID0gTlVMTDsKPiAgCj4gLQl0bXAgPSBJOTE1X1JFQUQoVFJBTlNfRERJX0ZVTkNfQ1RM KFRSQU5TQ09ERVJfRURQKSk7Cj4gLQlpZiAodG1wICYgVFJBTlNfRERJX0ZVTkNfRU5BQkxFKSB7 Cj4gLQkJZW51bSBwaXBlIHRyYW5zX2VkcF9waXBlOwo+IC0JCXN3aXRjaCAodG1wICYgVFJBTlNf RERJX0VEUF9JTlBVVF9NQVNLKSB7Cj4gLQkJZGVmYXVsdDoKPiAtCQkJV0FSTigxLCAidW5rbm93 biBwaXBlIGxpbmtlZCB0byBlZHAgdHJhbnNjb2RlclxuIik7Cj4gLQkJY2FzZSBUUkFOU19ERElf RURQX0lOUFVUX0FfT05PRkY6Cj4gLQkJY2FzZSBUUkFOU19ERElfRURQX0lOUFVUX0FfT046Cj4g LQkJCXRyYW5zX2VkcF9waXBlID0gUElQRV9BOwo+IC0JCQlicmVhazsKPiAtCQljYXNlIFRSQU5T X0RESV9FRFBfSU5QVVRfQl9PTk9GRjoKPiAtCQkJdHJhbnNfZWRwX3BpcGUgPSBQSVBFX0I7Cj4g LQkJCWJyZWFrOwo+IC0JCWNhc2UgVFJBTlNfRERJX0VEUF9JTlBVVF9DX09OT0ZGOgo+IC0JCQl0 cmFuc19lZHBfcGlwZSA9IFBJUEVfQzsKPiAtCQkJYnJlYWs7Cj4gLQkJfQo+IC0KPiAtCQlpZiAo dHJhbnNfZWRwX3BpcGUgPT0gY3J0Yy0+cGlwZSkKPiAtCQkJcGlwZV9jb25maWctPmNwdV90cmFu c2NvZGVyID0gVFJBTlNDT0RFUl9FRFA7Cj4gLQl9Cj4gKwlhY3RpdmUgPSBoc3dfZ2V0X3RyYW5z Y29kZXJfc3RhdGUoY3J0YywgcGlwZV9jb25maWcsICZwb3dlcl9kb21haW5fbWFzayk7Cj4gIAo+ IC0JcG93ZXJfZG9tYWluID0gUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVIocGlwZV9jb25maWctPmNw dV90cmFuc2NvZGVyKTsKPiAtCWlmICghaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxl ZChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKSkKPiAtCQlnb3RvIG91dDsKPiAtCXBvd2VyX2RvbWFp bl9tYXNrIHw9IEJJVChwb3dlcl9kb21haW4pOwo+IC0KPiAtCXRtcCA9IEk5MTVfUkVBRChQSVBF Q09ORihwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIpKTsKPiAtCWlmICghKHRtcCAmIFBJUEVD T05GX0VOQUJMRSkpCj4gKwlpZiAoIWFjdGl2ZSkKPiAgCQlnb3RvIG91dDsKPiAgCj4gIAloYXN3 ZWxsX2dldF9kZGlfcG9ydF9zdGF0ZShjcnRjLCBwaXBlX2NvbmZpZyk7Cj4gQEAgLTEwMDM4LDEz ICsxMDA1NSwxMSBAQCBzdGF0aWMgYm9vbCBoYXN3ZWxsX2dldF9waXBlX2NvbmZpZyhzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YywKPiAgCQlwaXBlX2NvbmZpZy0+cGl4ZWxfbXVsdGlwbGllciA9IDE7 Cj4gIAl9Cj4gIAo+IC0JcmV0ID0gdHJ1ZTsKPiAtCj4gIG91dDoKPiAgCWZvcl9lYWNoX3Bvd2Vy X2RvbWFpbihwb3dlcl9kb21haW4sIHBvd2VyX2RvbWFpbl9tYXNrKQo+ICAJCWludGVsX2Rpc3Bs YXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21haW4pOwo+ICAKPiAtCXJldHVybiByZXQ7 Cj4gKwlyZXR1cm4gYWN0aXZlOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpODQ1X3VwZGF0ZV9j dXJzb3Ioc3RydWN0IGRybV9jcnRjICpjcnRjLCB1MzIgYmFzZSwKPiAtLSAKPiAyLjEuNAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==