From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH 1/3] ib core: Make device counter infrastructure dynamic Date: Fri, 18 Mar 2016 17:42:40 +0200 Message-ID: <20160318154240.GJ25216@leon.nu> References: <20160315155441.222586021@linux.com> <20160315155455.173645653@linux.com> <20160317072354.GB25216@leon.nu> <20160318061659.GH25216@leon.nu> Reply-To: leon-2ukJVAZIZ/Y@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Bloch , Jason Gunthorpe , Steve Wise , Majd Dibbiny , alonvi-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, Mar 18, 2016 at 09:34:04AM -0500, Christoph Lameter wrote: > On Fri, 18 Mar 2016, Leon Romanovsky wrote: > > > Sure, and the question was "do you need to carry this semantic on and > > return NULL instead of ERR_PTR for alloc_stats_port call?" > > Yes I think that is most convenient and its customary to do it like that > unless there are special reasons why one wants to propagate an error code. Thanks, I'll take this suggestion into account while I'm reviewing submitted code. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html