From: Greg KH <greg@kroah.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, Mans Rullgard <mans@mansr.com>,
stable@vger.kernel.org, #@black.fi.intel.com,
v4.1+@black.fi.intel.com
Subject: Re: [PATCH v1 1/1] ata: sata_dwc_460ex: make driver works again
Date: Fri, 18 Mar 2016 10:33:45 -0700 [thread overview]
Message-ID: <20160318173345.GA19137@kroah.com> (raw)
In-Reply-To: <1458312535-105427-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Fri, Mar 18, 2016 at 04:48:55PM +0200, Andy Shevchenko wrote:
> This patch basically reverts three commits
> 8d5fe8d sata_dwc_460ex: indent an if statement
> db7a657f sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev
> 8b34448 sata_dwc_460ex: move to generic DMA driver
> to make driver works on _stable_ kernels only.
>
> The mentioned set has few flaws which are addressed in the continuation of this
> series. At that time no-one has a possibility to check that on an actual
> hardware. But now I have access to it and thus can be sure that everything
> works beforehand.
>
> The decision to revert is based on the fact of amount of efforts needed to back
> port necessary changes.
>
> Fixes: 8b3444852a2b ("sata_dwc_460ex: move to generic DMA driver")
> Cc: stable@vger.kernel.org # v4.1+
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Tejun, this is intended explicitly for stable kernels only (v4.1..v4.6-rcX).
> Mans and I are going to fix it in the upstrem this cycle. I have alredy send a
> patch series regarding DMA fixes.
>
> drivers/ata/sata_dwc_460ex.c | 753 +++++++++++++++++++++++++++++++++++--------
> 1 file changed, 623 insertions(+), 130 deletions(-)
That's not ok for a stable patch, sorry, please go read
Documentation/stable_kernel_rules.txt.
Just revert the individual patches instead, what's wrong with that?
thanks,
greg k-h
prev parent reply other threads:[~2016-03-18 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:48 [PATCH v1 1/1] ata: sata_dwc_460ex: make driver works again Andy Shevchenko
2016-03-18 17:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318173345.GA19137@kroah.com \
--to=greg@kroah.com \
--cc=#@black.fi.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=mans@mansr.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=v4.1+@black.fi.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.