From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mason <slash.tmp@free.fr>
Cc: Sebastian Frias <sf84@laposte.net>,
Daniel Mack <daniel@zonque.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Mans Rullgard <mans@mansr.com>,
Fabio Estevam <festevam@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB
Date: Fri, 18 Mar 2016 21:11:53 +0100 [thread overview]
Message-ID: <20160318201153.GR4292@pengutronix.de> (raw)
In-Reply-To: <56EC5788.3030509@free.fr>
Hello,
On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote:
> On 18/03/2016 20:12, Uwe Kleine-König wrote:
>
> > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:
> >
> >> What would you think of making at803x_link_change_notify() print a
> >> message every time it should do a reset but does not has a way to do it?
> >
> > Then this question is obsolete because the device doesn't probe.
>
> I don't understand this statement.
>
> What does it mean for a question to be obsolete?
If the driver doesn't probe because it cannot control the reset line,
you don't need to think about how it should behave in
at803x_link_change_notify without control of the reset line, because
this code isn't reached then.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-03-18 20:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:25 [PATCH] net: phy: at803x: don't depend on GPIOLIB Sebastian Frias
2016-03-18 12:12 ` Mason
2016-03-18 12:54 ` Uwe Kleine-König
2016-03-18 12:54 ` Uwe Kleine-König
2016-03-18 15:56 ` Sebastian Frias
2016-03-18 19:12 ` Uwe Kleine-König
2016-03-18 19:31 ` Mason
2016-03-18 20:11 ` Uwe Kleine-König [this message]
2016-03-18 20:44 ` Mason
2016-03-19 10:01 ` Måns Rullgård
2016-03-21 12:48 ` Sebastian Frias
2016-03-21 12:48 ` Sebastian Frias
2016-03-21 13:54 ` Uwe Kleine-König
2016-03-21 15:36 ` Sebastian Frias
2016-03-21 20:12 ` Uwe Kleine-König
2016-03-22 14:34 ` Sebastian Frias
2016-03-22 19:42 ` Uwe Kleine-König
2016-03-23 10:12 ` Sebastian Frias
2016-03-23 10:49 ` [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY Sebastian Frias
2016-03-23 17:40 ` David Miller
2016-03-23 19:42 ` Sergei Shtylyov
2016-03-24 9:55 ` Sebastian Frias
2016-03-24 10:10 ` Sebastian Frias
2016-03-24 13:40 ` Sergei Shtylyov
2016-03-23 10:17 ` [PATCH] net: phy: at803x: don't depend on GPIOLIB Mason
2016-03-23 10:39 ` Sergei Shtylyov
2016-03-23 10:55 ` Sebastian Frias
2016-03-22 14:34 ` Sebastian Frias
2016-03-21 20:15 ` Sergei Shtylyov
2016-03-21 20:41 ` Uwe Kleine-König
2016-03-21 21:56 ` Sergei Shtylyov
2016-03-22 14:53 ` Sebastian Frias
2016-03-22 14:39 ` Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318201153.GR4292@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=martin.blumenstingl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.