From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v7 5/7] libnvdimm: advertise 'call_dsm' support
Date: Fri, 18 Mar 2016 17:27:05 -0600 [thread overview]
Message-ID: <20160318232705.GD71733@tevye.fc.hp.com> (raw)
In-Reply-To: <CAPcyv4jSuKUv6KLCX1_cOH_GdR4ZkJRGucHAFibpNbnLo+=haA@mail.gmail.com>
On Wed, Mar 16, 2016 at 01:47:43PM -0700, Dan Williams wrote:
> On Wed, Mar 16, 2016 at 1:21 PM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> > On Tue, Mar 15, 2016 at 03:08:14PM -0700, Dan Williams wrote:
[..]
> > 3. sysfs extensions
> >
> > I had planned to do some type of extension for sysfs for passthru
> > after getting basic features agreed upon. But, i hadn't thought
> > it through deeply. As for:
> >
> > /sys/bus/nd/devices/nmem0/nfit/dsm_mask
> > /sys/bus/nd/devices/nmem0/nfit/family
> >
> > Don't we want:
> >
> > /sys/bus/nd/devices/nmem0/dsm_mask
> > /sys/bus/nd/devices/nmem0/family
> >
> > As the mask/family is associated with the dimm.
>
> Hmm, I think more like this:
>
> /sys/bus/nd/devices/nmem0/nfit/dsm_mask
> /sys/bus/nd/devices/nmem0/family
>
> The mask is associated with the dimm, but it is ACPI specific.
> However, you're right that the family id is truly generic and should
> be at the dimm level because the family type could span across
> non-ACPI architectures.
We could abstract it to "cmd_mask" and put it off nmem0 like
family. Same reasoning should apply. Just something to think
about.
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-03-18 23:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 21:32 [PATCH v7 0/7] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 1/7] ACPI / util: Fix acpi_evaluate_dsm() argument type Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 2/7] nvdimm: Add wrapper for IOCTL pass thru Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 3/7] nvdimm: Increase max envelope size for IOCTL Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 4/7] nvdimm: Add UUIDs Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 5/7] libnvdimm: advertise 'call_dsm' support Jerry Hoemann
2016-03-15 22:08 ` Dan Williams
2016-03-16 20:21 ` Jerry Hoemann
2016-03-16 20:47 ` Dan Williams
2016-03-16 23:31 ` Jerry Hoemann
2016-03-17 0:28 ` Dan Williams
2016-03-18 23:27 ` Jerry Hoemann [this message]
2016-03-15 21:32 ` [PATCH v7 6/7] nvdimm: Add IOCTL pass thru functions Jerry Hoemann
2016-03-15 21:32 ` [PATCH v7 7/7] tools/testing/nvdimm: 'call_dsm' support Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318232705.GD71733@tevye.fc.hp.com \
--to=jerry.hoemann@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.