All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: xfs_growfs causing "Metadata corruption detected at xfs_agf_read_verify"
Date: Mon, 21 Mar 2016 08:58:56 +1100	[thread overview]
Message-ID: <20160320215856.GO30721@dastard> (raw)
In-Reply-To: <20160318123107.GB8856@redhat.com>

On Fri, Mar 18, 2016 at 12:31:07PM +0000, Richard W.M. Jones wrote:
> On Thu, Mar 17, 2016 at 05:55:52PM -0500, Eric Sandeen wrote:
> > On 3/17/16 5:48 PM, Richard W.M. Jones wrote:
> > > 
> > > With recent kernels (or maybe xfsprogs?) we've noticed strange
> > > filesystem corruption after using xfs_growfs.
> > > 
> > > Examples:
> > > 
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1315895 (on aarch64)
> > > https://www.redhat.com/archives/libguestfs/2016-March/msg00113.html (x86_64)
> > > https://rwmj.wordpress.com/2015/11/04/virt-builder-fedora-23-image/#comment-15668 (x86_64)
> > > 
> > > Do these errors look familiar?  I don't yet have a simple test case,
> > > still working on that.
> > 
> > try:
> > http://oss.sgi.com/pipermail/xfs/2016-March/047683.html
> 
> I've tried this patch now, but I still can't get a solid reproducer
> (one that doesn't involve using aarch64).
> 
> I just tried to create a filesystem on kernel 4.6.0, grow it on 4.6.0,
> then copy it to another machine with 4.4.4.  However that didn't
> reproduce the bug, so I couldn't verify if the patch fixes the bug.
> (Maybe 4.4.4 is too new?)

4.4.4 has the fix already in it, through the stable kernel backport
process. i.e. the original kernel commit had this in it:

	 cc: <stable@vger.kernel.org> # 3.10 - 4.4

And so the fix is automatically appearing in stable kernels as they
are released. Hence the number of current supported kernels you can
reproduce this on is shrinking....

> Can you help me to understand under what circumstances this bug would
> appear, as far as you understand what's happening?

Take a stock 4.5.0 kernel, mkfs, mount, growfs, unmount go back to a
stock 4.4.0 kernel, mount (fails), xfs_repair v4.3.0 (warns, fixes),
xfs_repair v4.5.0 (clean, fixes).

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2016-03-20 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 22:48 xfs_growfs causing "Metadata corruption detected at xfs_agf_read_verify" Richard W.M. Jones
2016-03-17 22:55 ` Eric Sandeen
2016-03-18 12:31   ` Richard W.M. Jones
2016-03-20 21:58     ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160320215856.GO30721@dastard \
    --to=david@fromorbit.com \
    --cc=rjones@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.