From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] norm: new package
Date: Sun, 20 Mar 2016 23:01:27 +0100 [thread overview]
Message-ID: <20160320230127.56798c79@free-electrons.com> (raw)
In-Reply-To: <1457516142-7421-1-git-send-email-gustavo@zacarias.com.ar>
Hello,
On Wed, 9 Mar 2016 06:35:41 -0300, Gustavo Zacarias wrote:
> +define NORM_CONFIGURE_CMDS
> + (cd $(@D); \
> + $(TARGET_CONFIGURE_OPTS) \
> + ./waf configure --prefix=/usr \
> + )
The parenthesis here (and in the other commands) are not needed.
> +# install target doesn't install headers unfortunately...
> +define NORM_INSTALL_STAGING_CMDS
> + (cd $(@D); \
> + $(TARGET_MAKE_ENV) \
> + DESTDIR=$(STAGING_DIR) \
> + ./waf install; \
> + cp -f $(@D)/include/norm* $(STAGING_DIR)/usr/include \
And there's no reason for this headers copy to be inside the cd $(@D).
I've fixed those two issues and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-20 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 9:35 [Buildroot] [PATCH 1/2] norm: new package Gustavo Zacarias
2016-03-09 9:35 ` [Buildroot] [PATCH 2/2] zeromq: add norm support Gustavo Zacarias
2016-03-20 22:09 ` Thomas Petazzoni
2016-03-15 22:03 ` [Buildroot] [PATCH 1/2] norm: new package Peter Korsgaard
2016-03-15 22:14 ` Gustavo Zacarias
2016-03-15 22:19 ` Peter Korsgaard
2016-03-15 22:22 ` Gustavo Zacarias
2016-03-15 22:33 ` Peter Korsgaard
2016-03-15 22:39 ` Gustavo Zacarias
2016-03-20 22:01 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320230127.56798c79@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.