From: Al Viro <viro@ZenIV.linux.org.uk>
To: Theodore Ts'o <tytso@mit.edu>, Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dhowells@redhat.com, Goldwyn Rodrigues <rgoldwyn@suse.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
stable@vger.kernel.org, Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH 1/4] vfs: add file_dentry()
Date: Mon, 21 Mar 2016 05:22:53 +0000 [thread overview]
Message-ID: <20160321052252.GG17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160321050215.GD3331@thunk.org>
On Mon, Mar 21, 2016 at 01:02:15AM -0400, Theodore Ts'o wrote:
> I have this patch in the ext4.git tree, but I'd like to get an
> Acked-by from Al before I send a pull request to Linus.
>
> Al? Any objections to my sending in this change via the ext4 tree?
> - Ted
FWIW, I would rather add DCACHE_OP_REAL (set at d_set_d_op()
time) and turned that into
static inline struct dentry *d_real(const struct dentry *dentry)
{
if (unlikely(dentry->d_flags & DCACHE_OP_NATIVE_DENTRY))
returd dentry->d_op->d_real(dentry);
else
return dentry;
}
static inline struct dentry *file_dentry(const struct file *file)
{
return d_real(file->f_path.dentry);
}
and used ovl_dentry_real as ->d_real for overlayfs. Miklos, do you
see any problems with that variant?
next prev parent reply other threads:[~2016-03-21 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:02 [PATCH 1/4] vfs: add file_dentry() Miklos Szeredi
2016-03-17 9:02 ` [PATCH 2/4] nfs: use file_dentry() Miklos Szeredi
2016-03-17 9:02 ` [PATCH 3/4] ext4: use dget_parent() in ext4_file_open() Miklos Szeredi
2016-03-17 9:02 ` [PATCH 4/4] ext4: use file_dentry() Miklos Szeredi
2016-03-17 9:09 ` [PATCH 1/4] vfs: add file_dentry() Sedat Dilek
2016-03-17 9:33 ` Miklos Szeredi
2016-03-17 10:15 ` Sedat Dilek
2016-03-17 10:19 ` Sedat Dilek
2016-03-17 14:18 ` Theodore Ts'o
2016-03-21 5:02 ` Theodore Ts'o
2016-03-21 5:22 ` Al Viro [this message]
2016-03-22 6:24 ` Daniel Axtens
2016-03-21 5:28 ` Al Viro
2016-03-21 8:16 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321052252.GG17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=dja@axtens.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rgoldwyn@suse.com \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.