* [patch] mdio-sun4i: oops in error handling in probe
@ 2016-03-21 9:02 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-21 9:02 UTC (permalink / raw)
To: Florian Fainelli, Maxime Ripard; +Cc: Chen-Yu Tsai, netdev, kernel-janitors
We could end up dereferencing an error pointer when we call
regulator_disable().
Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c
index f70522c..1352965 100644
--- a/drivers/net/phy/mdio-sun4i.c
+++ b/drivers/net/phy/mdio-sun4i.c
@@ -122,6 +122,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
return -EPROBE_DEFER;
dev_info(&pdev->dev, "no regulator found\n");
+ data->regulator = NULL;
} else {
ret = regulator_enable(data->regulator);
if (ret)
@@ -137,7 +138,8 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
return 0;
err_out_disable_regulator:
- regulator_disable(data->regulator);
+ if (data->regulator)
+ regulator_disable(data->regulator);
err_out_free_mdiobus:
mdiobus_free(bus);
return ret;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] mdio-sun4i: oops in error handling in probe
@ 2016-03-21 9:02 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-21 9:02 UTC (permalink / raw)
To: Florian Fainelli, Maxime Ripard; +Cc: Chen-Yu Tsai, netdev, kernel-janitors
We could end up dereferencing an error pointer when we call
regulator_disable().
Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c
index f70522c..1352965 100644
--- a/drivers/net/phy/mdio-sun4i.c
+++ b/drivers/net/phy/mdio-sun4i.c
@@ -122,6 +122,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
return -EPROBE_DEFER;
dev_info(&pdev->dev, "no regulator found\n");
+ data->regulator = NULL;
} else {
ret = regulator_enable(data->regulator);
if (ret)
@@ -137,7 +138,8 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
return 0;
err_out_disable_regulator:
- regulator_disable(data->regulator);
+ if (data->regulator)
+ regulator_disable(data->regulator);
err_out_free_mdiobus:
mdiobus_free(bus);
return ret;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] mdio-sun4i: oops in error handling in probe
2016-03-21 9:02 ` Dan Carpenter
@ 2016-03-21 10:11 ` Chen-Yu Tsai
-1 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2016-03-21 10:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Florian Fainelli, Maxime Ripard, Chen-Yu Tsai, netdev,
kernel-janitors
On Mon, Mar 21, 2016 at 5:02 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We could end up dereferencing an error pointer when we call
> regulator_disable().
>
> Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] mdio-sun4i: oops in error handling in probe
@ 2016-03-21 10:11 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2016-03-21 10:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Florian Fainelli, Maxime Ripard, Chen-Yu Tsai, netdev,
kernel-janitors
On Mon, Mar 21, 2016 at 5:02 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We could end up dereferencing an error pointer when we call
> regulator_disable().
>
> Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mdio-sun4i: oops in error handling in probe
2016-03-21 9:02 ` Dan Carpenter
@ 2016-03-21 15:30 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-21 15:30 UTC (permalink / raw)
To: dan.carpenter; +Cc: f.fainelli, maxime.ripard, wens, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 21 Mar 2016 12:02:31 +0300
> We could end up dereferencing an error pointer when we call
> regulator_disable().
>
> Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] mdio-sun4i: oops in error handling in probe
@ 2016-03-21 15:30 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-21 15:30 UTC (permalink / raw)
To: dan.carpenter; +Cc: f.fainelli, maxime.ripard, wens, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 21 Mar 2016 12:02:31 +0300
> We could end up dereferencing an error pointer when we call
> regulator_disable().
>
> Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-21 15:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 9:02 [patch] mdio-sun4i: oops in error handling in probe Dan Carpenter
2016-03-21 9:02 ` Dan Carpenter
2016-03-21 10:11 ` Chen-Yu Tsai
2016-03-21 10:11 ` Chen-Yu Tsai
2016-03-21 15:30 ` David Miller
2016-03-21 15:30 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.