All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Marc Marí" <markmb@redhat.com>
Cc: "Marc Marí" <marc.mari.barcelo@gmail.com>,
	"Gabriel L. Somlo" <somlo@cmu.edu>,
	qemu-devel@nongnu.org, "Kevin O'Connor" <kevin@koconnor.net>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>, Laszlo <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version
Date: Mon, 21 Mar 2016 11:14:16 +0000	[thread overview]
Message-ID: <20160321111416.GC19398@redhat.com> (raw)
In-Reply-To: <1454065944-15887-1-git-send-email-markmb@redhat.com>

My notes on this patch:

* It applies and compiles fine with current qemu on Linux/x86_64 host.
  However after building I had to do:

  cp pc-bios/optionrom/linuxboot_dma.bin pc-bios/

  I wasn't sure if that was supposed to be done automatically.

* It reduces libguestfs appliance boot time by about ½ second
  (2.00 s -> 1.53 s), so that's excellent.

* Overhead of BIOS-to-kernel drops from nearly 50% to under 20% of the
  total libguestfs appliance boot time.  SeaBIOS is still using 0.27
  seconds, of which at least 0.12 seconds is PCI bus scanning.

Anyway, all in all, a good change!

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

      parent reply	other threads:[~2016-03-21 11:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 11:12 [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version Marc Marí
2016-01-29 15:25 ` Stefan Hajnoczi
2016-02-02 11:06 ` Gerd Hoffmann
2016-02-02 12:04   ` Gerd Hoffmann
2016-02-02 13:07     ` Marc Marí
2016-02-02 14:23       ` Gerd Hoffmann
2016-02-02 15:04         ` Laszlo Ersek
2016-02-03  8:44           ` Gerd Hoffmann
2016-02-03 11:48             ` Laszlo Ersek
2016-02-03 12:57               ` Gerd Hoffmann
2016-02-02 12:58   ` Marc Marí
2016-02-03  9:47     ` Stefan Hajnoczi
2016-02-22 11:56 ` Vladimir Sementsov-Ogievskiy
2016-02-23  9:51   ` Stefan Hajnoczi
2016-03-21 11:14 ` Richard W.M. Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321111416.GC19398@redhat.com \
    --to=rjones@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marc.mari.barcelo@gmail.com \
    --cc=markmb@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=somlo@cmu.edu \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.