From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756191AbcCUOL5 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 10:11:57 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:36538 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755289AbcCUOLy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 10:11:54 -0400
Date: Mon, 21 Mar 2016 15:11:45 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched: Add preempt checks in preempt_schedule() code
Message-ID: <20160321141145.GV6344@twins.programming.kicks-ass.net>
References: <20160318130602.25f6c9cd@gandalf.local.home>
 <20160321092746.GR6344@twins.programming.kicks-ass.net>
 <20160321092932.2d1dce5a@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160321092932.2d1dce5a@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 21, 2016 at 09:29:32AM -0400, Steven Rostedt wrote:
> On Mon, 21 Mar 2016 10:27:46 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > So no real objection to the patch except this naming.
> > 
> > It doesn't 'check', it does preempt-latency tracing. So could we rename
> > this to something like:
> > 
> > 	preempt_{dis,en}able_latency()
> > 
> > or somesuch?
> 
> What about:
> 
>  preempt_enable_trace() or preempt_enable_trace_test()?

So the problem with preempt_enable_trace() is that we just called a
_notrace(), and while I now know these are two different trace thingies,
I might have forgotten that in a few days.