From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Stephane Eranian <eranian@google.com>,
Borislav Petkov <bp@suse.de>,
"Andi Kleen (ak@linux.intel.com)" <ak@linux.intel.com>
Subject: Re: [patch 2/4] x86/perf/intel/cstate: Sanitize probing
Date: Mon, 21 Mar 2016 15:42:18 +0100 [thread overview]
Message-ID: <20160321144218.GW6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077058A7665@SHSMSX103.ccr.corp.intel.com>
On Mon, Mar 21, 2016 at 02:19:27PM +0000, Liang, Kan wrote:
> > - /* Probe the cstate events. */
> > - for (i = 0; i < max_event_nr; i++) {
> > - if (!msr[i].test(i) || rdmsrl_safe(msr[i].msr, &val))
> > - msr[i].attr = NULL;
> > - }
>
> I think we need to update msr[i].attr as well.
> Because in cstate_pmu_event_init we still need it to do check.
Yeah, this is exploding on all sides..
next prev parent reply other threads:[~2016-03-21 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 18:59 [patch 0/4] x86/perf/intel/cstate: Fix cpu hotplug handling and make it modular Thomas Gleixner
2016-03-20 18:59 ` [patch 1/4] x86/perf/intel/cstate: Make hotplug handling actually work Thomas Gleixner
2016-03-31 9:20 ` [tip:perf/core] x86/perf/intel/cstate: Make cstate " tip-bot for Thomas Gleixner
2016-03-20 18:59 ` [patch 3/4] x86/perf/intel/cstate: Sanitize error handling Thomas Gleixner
2016-03-31 9:21 ` [tip:perf/core] " tip-bot for Thomas Gleixner
2016-03-20 18:59 ` [patch 2/4] x86/perf/intel/cstate: Sanitize probing Thomas Gleixner
2016-03-21 14:19 ` Liang, Kan
2016-03-21 14:42 ` Peter Zijlstra [this message]
2016-03-21 15:03 ` Thomas Gleixner
2016-03-21 15:04 ` Thomas Gleixner
2016-03-31 9:21 ` [tip:perf/core] " tip-bot for Thomas Gleixner
2016-03-20 18:59 ` [patch 4/4] x86/perf/intel/cstate: Modularize driver Thomas Gleixner
2016-03-31 9:21 ` [tip:perf/core] " tip-bot for Thomas Gleixner
2016-03-21 15:01 ` [patch 0/4] x86/perf/intel/cstate: Fix cpu hotplug handling and make it modular Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321144218.GW6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.