From: Shaohua Li <shli@kernel.org>
To: Wei Fang <fangwei1@huawei.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] md:raid1: fix a dead loop when read from a WriteMostly disk
Date: Mon, 21 Mar 2016 10:29:33 -0700 [thread overview]
Message-ID: <20160321172933.GA66333@kernel.org> (raw)
In-Reply-To: <1458559112-27683-1-git-send-email-fangwei1@huawei.com>
On Mon, Mar 21, 2016 at 07:18:32PM +0800, Wei Fang wrote:
> If first_bad == this_sector when we get the WriteMostly disk
> in read_balance(), valid disk will be returned with zero
> max_sectors. It'll lead to a dead loop in make_request(), and
> OOM will happen because of endless allocation of struct bio.
>
> Since we can't get data from this disk in this case, so
> continue for another disk.
Good catch, applied.
Thanks,
Shaohua
prev parent reply other threads:[~2016-03-21 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:18 [PATCH] md:raid1: fix a dead loop when read from a WriteMostly disk Wei Fang
2016-03-21 17:29 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321172933.GA66333@kernel.org \
--to=shli@kernel.org \
--cc=fangwei1@huawei.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.