From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "To .LiMit" <348958453@qq.com>
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]rtllib&rtl8192x function naming codestyle change to kernel style
Date: Mon, 21 Mar 2016 15:16:46 -0400 [thread overview]
Message-ID: <20160321191646.GC27613@kroah.com> (raw)
In-Reply-To: <tencent_0C30B0711DC5A0D477161C10@qq.com>
On Sun, Mar 20, 2016 at 09:47:29PM +0800, To .LiMit wrote:
> Hi, I saw drivers/staging/rtl8192e/TODO, checked the files within drivers/staging/rtl8192e/, and I found their function naming codestyle is camelcase, I changed them. But I don't know if I should change all variable naming codestyle or not, so I just changed the function naming of the patch.
>
> Regards,
>
> Signed-off-by:Ming Li
We need an email address for the signed-off-by line, and it has to match
your from: line.
Also, please provide a proper changelog entry. And only change one
thing at a time, so for this, change only one function per patch.
thanks,
greg k-h
parent reply other threads:[~2016-03-21 19:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tencent_0C30B0711DC5A0D477161C10@qq.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321191646.GC27613@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=348958453@qq.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.