Re: [Outreachy kernel] [PATCH] Staging: lustre: Do not add space between function name and open parenthesis.

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 21, 2016 at 08:28:16PM +0530, Sandhya Bankar wrote:
> Do not add space between function name and open parenthesis.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  .../staging/lustre/lustre/osc/osc_cl_internal.h    | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> index d55d04d..3dfe5f6 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> +++ b/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
> @@ -417,20 +417,20 @@ extern struct lu_context_key osc_session_key;
>  int osc_lock_init(const struct lu_env *env,
>  		  struct cl_object *obj, struct cl_lock *lock,
>  		  const struct cl_io *io);
> -int osc_io_init  (const struct lu_env *env,
> -		  struct cl_object *obj, struct cl_io *io);
> -int osc_req_init (const struct lu_env *env, struct cl_device *dev,
> -		  struct cl_req *req);
> +int osc_io_init(const struct lu_env *env,
> +		struct cl_object *obj, struct cl_io *io);
> +int osc_req_init(const struct lu_env *env, struct cl_device *dev,
> +		 struct cl_req *req);
>  struct lu_object *osc_object_alloc(const struct lu_env *env,
>  				   const struct lu_object_header *hdr,
>  				   struct lu_device *dev);
>  int osc_page_init(const struct lu_env *env, struct cl_object *obj,
>  		  struct cl_page *page, struct page *vmpage);
>  
> -void osc_index2policy  (ldlm_policy_data_t *policy, const struct cl_object *obj,
> -			pgoff_t start, pgoff_t end);
> -int  osc_lvb_print     (const struct lu_env *env, void *cookie,
> -			lu_printer_t p, const struct ost_lvb *lvb);
> +void osc_index2policy(ldlm_policy_data_t *policy, const struct cl_object *obj,
> +		      pgoff_t start, pgoff_t end);
> +int  osc_lvb_print(const struct lu_env *env, void *cookie,
> +		   lu_printer_t p, const struct ost_lvb *lvb);

Does the code look better now?  Before your patch, it looked much nicer,
don't you think?

thanks,

greg k-h