From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tina Ruchandani <ruchandani.tina@gmail.com>,
y2038@lists.linaro.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: nosy: Replace timeval with timespec64
Date: Tue, 22 Mar 2016 15:27:41 +0100 [thread overview]
Message-ID: <20160322152741.61eb2615@kant> (raw)
In-Reply-To: <3575481.G5vcZLmfxK@wuerfel>
On Mar 21 Arnd Bergmann wrote:
>>> On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote:
>>>> 'struct timeval' uses a 32 bit field for its 'seconds' value which
>>>> will overflow in year 2038 and beyond. This patch replaces the use
>>>> of timeval in nosy.c with timespec64 which doesn't suffer from y2038
>>>> issue. The code is correct as is - since it is only using the
>>>> microseconds portion of timeval. However, this patch does the
>>>> replacement as part of a larger effort to remove all instances of
>>>> 'struct timeval' from the kernel (that would help identify cases
>>>> where the code is actually broken).
>>>>
>>>> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
[...]
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Committed to linux1394.git.
I will try to get this pulled upstream in the next few days.
--
Stefan Richter
-======----- --== =-==-
http://arcgraph.de/sr/
prev parent reply other threads:[~2016-03-22 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 5:59 [PATCH] firewire: nosy: Replace timeval with timespec64 Tina Ruchandani
2016-03-21 19:55 ` Arnd Bergmann
2016-03-21 20:19 ` Stefan Richter
2016-03-21 21:36 ` Arnd Bergmann
2016-03-22 14:27 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322152741.61eb2615@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=ruchandani.tina@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.