All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de,
	mcgrof@suse.com, jgross@suse.com, paul.gortmaker@windriver.com,
	konrad.wilk@oracle.com, elliott@hpe.com, x86@kernel.org,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled
Date: Tue, 22 Mar 2016 18:01:35 +0100	[thread overview]
Message-ID: <20160322170135.GE5656@pd.tnic> (raw)
In-Reply-To: <1458175619-32206-3-git-send-email-toshi.kani@hpe.com>

Subject: [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled

s/ MSR//

On Wed, Mar 16, 2016 at 06:46:57PM -0600, Toshi Kani wrote:
> get_mtrr_state() calls pat_init() on BSP even if MTRR is disabled
> by its MSR.

s/by its MSR//

> This causes pat_init() to be called on BSP only since APs do not call

This doesn't cause that - get_mtrr_state() is called only on the BSP by
mtrr_bp_init().

> pat_init() when MTRR is disabled. This inconsistency between BSP and
> APs leads undefined behavior.

      leads to


> Move BSP's PAT init code from get_mtrr_state() to mtrr_bp_pat_init().
> Change mtrr_bp_init() to call mtrr_bp_pat_init() if MTRR is enabled.

No need for those.

> This keeps BSP's calling condition to pat_init() consistent with AP's,
> mtrr_ap_init() and mtrr_aps_init().

This one is fine.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

  parent reply	other threads:[~2016-03-22 17:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  0:46 [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-17  0:46 ` [PATCH v2 3/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Toshi Kani
2016-03-22 17:00   ` Borislav Petkov
2016-03-22 21:53     ` Toshi Kani
2016-03-23  8:44       ` Borislav Petkov
2016-03-23 15:53         ` Toshi Kani
2016-03-23 15:53         ` Toshi Kani
2016-03-23 21:47           ` Toshi Kani
2016-03-23 21:47           ` Toshi Kani
2016-03-23  8:44       ` Borislav Petkov
2016-03-22 21:53     ` Toshi Kani
2016-03-22 17:00   ` Borislav Petkov
2016-03-17  0:46 ` Toshi Kani
2016-03-17  0:46 ` [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-22 17:01   ` Borislav Petkov
2016-03-22 17:01   ` Borislav Petkov [this message]
2016-03-22 22:02     ` Toshi Kani
2016-03-22 22:02     ` Toshi Kani
2016-03-17  0:46 ` [PATCH v2 5/6] x86/xen, pat: Remove PAT table init code from Xen Toshi Kani
2016-03-17  0:46 ` [PATCH v2 5/6] x86/xen,pat: " Toshi Kani
2016-03-22 17:02   ` [PATCH v2 5/6] x86/xen, pat: " Borislav Petkov
2016-03-22 17:02   ` [PATCH v2 5/6] x86/xen,pat: " Borislav Petkov
2016-03-23  6:08     ` Juergen Gross
2016-03-23  6:08     ` [PATCH v2 5/6] x86/xen, pat: " Juergen Gross
2016-03-17  0:46 ` [PATCH v2 6/6] x86/pat: Document PAT initializations Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-22 17:02   ` Borislav Petkov
2016-03-22 17:02   ` Borislav Petkov
2016-03-22 22:15     ` Toshi Kani
2016-03-22 22:15     ` Toshi Kani
2016-03-22 16:59 ` [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Borislav Petkov
2016-03-22 21:40   ` Toshi Kani
2016-03-23  8:51     ` Borislav Petkov
2016-03-23  8:51     ` Borislav Petkov
2016-03-23 15:49       ` Toshi Kani
2016-03-23 15:49       ` Toshi Kani
2016-03-22 21:40   ` Toshi Kani
2016-03-22 16:59 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322170135.GE5656@pd.tnic \
    --to=bp@suse.de \
    --cc=elliott@hpe.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.