All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [Buildroot PATCH v2 1/1] raptor: new package
Date: Tue, 22 Mar 2016 21:40:22 +0200	[thread overview]
Message-ID: <20160322194021.GP2780@tarshish> (raw)
In-Reply-To: <1458641641-17752-1-git-send-email-nitin.mendiratta@rockwellcollins.com>

Hi Nitin,

On Tue, Mar 22, 2016 at 03:44:01PM +0530, Nitin Mendiratta wrote:
> +ifeq ($(BR2_PACKAGE_LIBCURL),y)
> +RAPTOR_DEPENDENCIES += libcurl
> +RAPTOR_CONF_OPTS += --with-curl-config=$(STAGING_DIR)/usr/bin/curl-config
> +endif

Please add an 'else' clause that disables libcurl using --with-curl-config=no. 
The same goes for the two other optional dependencies.

> +ifeq ($(BR2_PACKAGE_YAJL),y)
> +RAPTOR_DEPENDENCIES += yajl
> +RAPTOR_CONF_ENV += LIBS="-lm"
> +RAPTOR_CONF_OPTS += --with-yajl-config=$(STAGING_DIR)/usr/bin/yajl-config

The yajl package does not provide yajl-config, and raptor configure does not 
support --with-yajl-config. Should be

  RAPTOR_CONF_OPTS += --with-yajl=$(STAGING_DIR)/usr/

instead.

> +endif
> +
> +ifeq ($(BR2_PACKAGE_ICU),y)
> +RAPTOR_DEPENDENCIES += icu
> +RAPTOR_CONF_OPTS += --with-icu-config=$(STAGING_DIR)/usr/bin/icu-config
> +endif

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2016-03-22 19:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 10:14 [Buildroot] [Buildroot PATCH v2 1/1] raptor: new package Nitin Mendiratta
2016-03-22 19:40 ` Baruch Siach [this message]
2016-03-26 18:15 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322194021.GP2780@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.