From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@fr.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: move POWER8 Book4 regs in their own routine
Date: Wed, 23 Mar 2016 11:39:20 +1100 [thread overview]
Message-ID: <20160323003920.GL23586@voom.redhat.com> (raw)
In-Reply-To: <1458656593-7735-1-git-send-email-clg@fr.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
On Tue, Mar 22, 2016 at 03:23:13PM +0100, Cédric Le Goater wrote:
> commit fce55481360d "ppc: A couple more dummy POWER8 Book4 regs"
> squashed in to rapidly a set of POWER8 Book4 regs in the wrong
> routine. This patch introduces the missing gen_spr_power8_book4()
> routine to fix their location.
>
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
Applied to ppc-for-2.6, thanks.
> ---
> target-ppc/translate_init.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> Index: qemu-dgibson-for-2.6.git/target-ppc/translate_init.c
> ===================================================================
> --- qemu-dgibson-for-2.6.git.orig/target-ppc/translate_init.c
> +++ qemu-dgibson-for-2.6.git/target-ppc/translate_init.c
> @@ -8018,6 +8018,13 @@ static void gen_spr_power8_ic(CPUPPCStat
> &spr_read_generic, SPR_NOACCESS,
> &spr_read_generic, &spr_write_generic,
> 0);
> +#endif
> +}
> +
> +static void gen_spr_power8_book4(CPUPPCState *env)
> +{
> + /* Add a number of P8 book4 registers */
> +#if !defined(CONFIG_USER_ONLY)
> spr_register_kvm(env, SPR_ACOP, "ACOP",
> SPR_NOACCESS, SPR_NOACCESS,
> &spr_read_generic, &spr_write_generic,
> @@ -8086,6 +8093,7 @@ static void init_proc_book3s_64(CPUPPCSt
> gen_spr_power8_pspb(env);
> gen_spr_vtb(env);
> gen_spr_power8_ic(env);
> + gen_spr_power8_book4(env);
> }
> if (version < BOOK3S_CPU_POWER8) {
> gen_spr_book3s_dbg(env);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-23 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 14:23 [Qemu-devel] [PATCH] ppc: move POWER8 Book4 regs in their own routine Cédric Le Goater
2016-03-23 0:39 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323003920.GL23586@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=clg@fr.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.