From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: [PATCH v4 14/23] ncr5380: Reduce max_lun limit Date: Wed, 23 Mar 2016 21:10:23 +1100 Message-ID: <20160323101012.921725572@telegraphics.com.au> References: <20160323101009.341929635@telegraphics.com.au> Return-path: Content-Disposition: inline; filename=ncr5380-max_lun Sender: linux-scsi-owner@vger.kernel.org To: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ondrej Zary , Sam Creasey List-Id: linux-m68k@vger.kernel.org The driver has a limit of eight LUs because of the byte-sized bitfield that is used for busy flags. That means the maximum LUN is 7. The default is 8. Signed-off-by: Finn Thain Tested-by: Michael Schmitz Tested-by: Ondrej Zary Reviewed-by: Hannes Reinecke --- Changed since v1: - Reduce shost->max_lun limit instead of adding 'MAX_LUN' limit. --- drivers/scsi/NCR5380.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2016-03-23 21:09:53.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2016-03-23 21:09:56.000000000 +1100 @@ -488,6 +488,8 @@ static int NCR5380_init(struct Scsi_Host int i; unsigned long deadline; + instance->max_lun = 7; + hostdata->host = instance; hostdata->id_mask = 1 << instance->this_id; hostdata->id_higher_mask = 0; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279AbcCWKSR (ORCPT ); Wed, 23 Mar 2016 06:18:17 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:43711 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754717AbcCWKPT (ORCPT ); Wed, 23 Mar 2016 06:15:19 -0400 Message-Id: <20160323101012.921725572@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Wed, 23 Mar 2016 21:10:23 +1100 From: Finn Thain To: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , , , Cc: Ondrej Zary , Sam Creasey Subject: [PATCH v4 14/23] ncr5380: Reduce max_lun limit References: <20160323101009.341929635@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-max_lun Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver has a limit of eight LUs because of the byte-sized bitfield that is used for busy flags. That means the maximum LUN is 7. The default is 8. Signed-off-by: Finn Thain Tested-by: Michael Schmitz Tested-by: Ondrej Zary Reviewed-by: Hannes Reinecke --- Changed since v1: - Reduce shost->max_lun limit instead of adding 'MAX_LUN' limit. --- drivers/scsi/NCR5380.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux/drivers/scsi/NCR5380.c =================================================================== --- linux.orig/drivers/scsi/NCR5380.c 2016-03-23 21:09:53.000000000 +1100 +++ linux/drivers/scsi/NCR5380.c 2016-03-23 21:09:56.000000000 +1100 @@ -488,6 +488,8 @@ static int NCR5380_init(struct Scsi_Host int i; unsigned long deadline; + instance->max_lun = 7; + hostdata->host = instance; hostdata->id_mask = 1 << instance->this_id; hostdata->id_higher_mask = 0;