From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Date: Wed, 23 Mar 2016 10:45:42 -0600 Message-ID: <20160323164542.GC16336@obsidianresearch.com> References: <1458713769-11800-1-git-send-email-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1458713769-11800-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: "moderated list:TPM DEVICE DRIVER" , open list List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote: > Dropped the field 'base' from struct tpm_vendor_specific and migrated > it to the private structures of tpm_atmel and tpm_nsc. > > Signed-off-by: Jarkko Sakkinen > +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv) This should be a static inline function not a define > +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv) Ditto Otherwise looks ok Reviewed-by: Jason Gunthorpe Jason ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932594AbcCWQps (ORCPT ); Wed, 23 Mar 2016 12:45:48 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:53237 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754534AbcCWQpq (ORCPT ); Wed, 23 Mar 2016 12:45:46 -0400 Date: Wed, 23 Mar 2016 10:45:42 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Message-ID: <20160323164542.GC16336@obsidianresearch.com> References: <1458713769-11800-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458713769-11800-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote: > Dropped the field 'base' from struct tpm_vendor_specific and migrated > it to the private structures of tpm_atmel and tpm_nsc. > > Signed-off-by: Jarkko Sakkinen > +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv) This should be a static inline function not a define > +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv) Ditto Otherwise looks ok Reviewed-by: Jason Gunthorpe Jason