All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org,
	tony.luck@intel.com, brgerst@gmail.com, peterz@infradead.org,
	bp@alien8.de, tglx@linutronix.de, dsahern@gmail.com,
	dvlasenk@redhat.com, jolsa@redhat.com, luto@amacapital.net,
	mingo@kernel.org, acme@redhat.com, torvalds@linux-foundation.org,
	namhyung@kernel.org, vincent.weaver@maine.edu,
	alexander.shishkin@linux.intel.com,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf/x86/cqm: Fix CQM handling of grouping events into a cache_group
Date: Wed, 23 Mar 2016 20:14:38 +0000	[thread overview]
Message-ID: <20160323201438.GH11676@codeblueprint.co.uk> (raw)
In-Reply-To: <alpine.DEB.2.10.1603211109210.25124@vshiva-Udesk>

On Mon, 21 Mar, at 11:14:37AM, Vikas Shivappa wrote:
> 
> 
> Before MBM , the below condition was never hit because we had only one event ?
> 
> -       if (a->hw.target == b->hw.target)
> +       if (a->hw.target == b->hw.target) {
> +               b->hw.is_group_event = true;
> 
> We are trying to address this for cases where different MBM(local or total)
> and cqm events are grouped into one RMID.
 
I can't test these changes, so I'm only working from memory, but I
seem to recall that this condition is hit if monitoring simultaneously
from two invocations of perf. It's also possible to have pid/tid
groups overlapping, and that needs to be handled.

> Which is the case which led to duplicate values ?

Good question. Try monitoring a multithread process with these changes
and see if you get duplicate values reported.

  reply	other threads:[~2016-03-23 20:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 23:32 [PATCH V6 0/6] Intel memory b/w monitoring support Vikas Shivappa
2016-03-10 23:32 ` [PATCH 1/6] x86/perf/intel/cqm: Fix cqm handling of grouping events into a cache_group Vikas Shivappa
2016-03-21  9:51   ` [tip:perf/urgent] perf/x86/cqm: Fix CQM " tip-bot for Vikas Shivappa
2016-03-21 14:57     ` Matt Fleming
2016-03-21 18:14       ` Vikas Shivappa
2016-03-23 20:14         ` Matt Fleming [this message]
2016-03-23 22:49           ` Vikas Shivappa
2016-03-10 23:32 ` [PATCH 2/6] x86/perf/intel/cqm: Fix cqm memory leak and notifier leak Vikas Shivappa
2016-03-21  9:51   ` [tip:perf/urgent] perf/x86/cqm: Fix CQM " tip-bot for Vikas Shivappa
2016-03-10 23:32 ` [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init Vikas Shivappa
2016-03-21  9:52   ` [tip:perf/urgent] perf/x86/mbm: Add " tip-bot for Vikas Shivappa
2016-03-10 23:32 ` [PATCH 4/6] x86/mbm: Memory bandwidth monitoring event management Vikas Shivappa
2016-03-11 19:26   ` Tony Luck
2016-03-21  9:52     ` [tip:perf/urgent] perf/x86/mbm: Add memory " tip-bot for Tony Luck
2016-03-10 23:32 ` [PATCH 5/6] x86/mbm: RMID Recycling MBM changes Vikas Shivappa
2016-03-21  9:53   ` [tip:perf/urgent] perf/x86/mbm: Implement RMID recycling tip-bot for Vikas Shivappa
2016-03-21 15:09     ` Matt Fleming
2016-03-21 18:27       ` Vikas Shivappa
2016-03-23 20:59         ` Matt Fleming
2016-03-10 23:32 ` [PATCH 6/6] x86/mbm: Add support for MBM counter overflow handling Vikas Shivappa
2016-03-11 19:26   ` Tony Luck
2016-03-21  9:53     ` [tip:perf/urgent] perf/x86/mbm: " tip-bot for Vikas Shivappa
2016-03-11 22:54 ` [PATCH V6 0/6] Intel memory b/w monitoring support Peter Zijlstra
2016-03-11 23:22   ` Vikas Shivappa
2016-03-11 23:25     ` Vikas Shivappa
2016-03-11 23:45   ` Luck, Tony
2016-03-12  1:56   ` Luck, Tony
2016-03-12  7:53     ` Peter Zijlstra
2016-03-12 16:14       ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323201438.GH11676@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vikas.shivappa@linux.intel.com \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.