All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: staging/rdma/hfi1: use mod_timer when appropriate
Date: Wed, 23 Mar 2016 23:48:17 +0300	[thread overview]
Message-ID: <20160323204817.GA14975@mwanda> (raw)

Hello Mike Marciniszyn,

The patch 633d27399514: "staging/rdma/hfi1: use mod_timer when
appropriate" from Feb 4, 2016, leads to the following static checker
warning:

	drivers/staging/rdma/hfi1/rc.c:1500 do_rc_ack()
	info: ignoring unreachable code.

drivers/staging/rdma/hfi1/rc.c
  1487                  default:
  1488                          /* Ignore other reserved NAK error codes */
  1489                          goto reserved;
  1490                  }
  1491                  qp->s_retry = qp->s_retry_cnt;
  1492                  qp->s_rnr_retry = qp->s_rnr_retry_cnt;
  1493                  goto bail_stop;
  1494  
  1495          default:                /* 2: reserved */
  1496  reserved:
  1497                  /* Ignore reserved NAK codes. */
  1498                  goto bail_stop;
  1499          }
  1500          return ret;
                ^^^^^^^^^^
Not reachable.

  1501  bail_stop:
  1502          hfi1_stop_rc_timers(qp);
  1503          return ret;
  1504  }


regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2016-03-23 20:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323204817.GA14975@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.