From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfs: set up inode operation vectors later
Date: Thu, 24 Mar 2016 10:05:00 +1100 [thread overview]
Message-ID: <20160323230500.GZ30721@dastard> (raw)
In-Reply-To: <1458740935-31260-3-git-send-email-hch@lst.de>
On Wed, Mar 23, 2016 at 02:48:53PM +0100, Christoph Hellwig wrote:
> In the next patch we'll set up different inode operations for inline vs
> out of line symlinks, for that we need to make sure the flags are already
> set up properly.
....
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index fb7dc61..f08d91c 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -181,6 +181,8 @@ xfs_generic_create(
> }
> #endif
>
> + xfs_setup_iops(ip);
> +
> if (tmpfile)
> d_tmpfile(dentry, inode);
> else
> @@ -368,6 +370,8 @@ xfs_vn_symlink(
> if (unlikely(error))
> goto out_cleanup_inode;
>
> + xfs_setup_iops(cip);
> +
> d_instantiate(dentry, inode);
> xfs_finish_inode_setup(cip);
I think there are more places than this that need xfs_setup_iops()
calls - a quick look around makes me think they need to be paired
with every path that calls xfs_finish_inode_setup().
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-23 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:48 support RCU lookups for inline symlinks Christoph Hellwig
2016-03-23 13:48 ` [PATCH 1/4] xfs: factor out a helper to initialize a local format inode fork Christoph Hellwig
2016-03-23 13:48 ` [PATCH 2/4] xfs: set up inode operation vectors later Christoph Hellwig
2016-03-23 23:05 ` Dave Chinner [this message]
2016-03-23 23:26 ` Christoph Hellwig
2016-03-23 23:45 ` Dave Chinner
2016-03-23 13:48 ` [PATCH 3/4] xfs: use ->readlink to implement the readlink_by_handle ioctl Christoph Hellwig
2016-03-23 13:48 ` [PATCH 4/4] xfs: optimize inline symlinks Christoph Hellwig
2016-04-05 21:55 ` support RCU lookups for " Dave Chinner
2016-04-07 23:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323230500.GZ30721@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.