From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.com>, Tejun Heo <tj@kernel.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org,
Byungchul Park <byungchul.park@lge.com>, Jan Kara <jack@suse.cz>
Subject: Re: [RFC][PATCH v6 1/2] printk: Make printk() completely async
Date: Thu, 24 Mar 2016 11:24:35 +0900 [thread overview]
Message-ID: <20160324022435.GA25607@swordfish> (raw)
In-Reply-To: <20160323100420.GD5522@pathway.suse.cz>
On (03/23/16 11:04), Petr Mladek wrote:
[..]
> if (!need_flush_console)
> schedule()
>
> # did one unnecessary
> # cycle to get asleep
OK. well, didn't consider it to be a problem, but I'll make it
symmetric:
we set need_flush_console under logbuf lock,
we clear it under logbuf lock.
should be simpler.
> PS: If you touch the code, please rename printing_func() to
> printk_kthread_func() to make it more clear what it does.
oh, yes, was going to do it but somehow forgot.
-ss
next prev parent reply other threads:[~2016-03-24 2:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 17:25 [RFC][PATCH v6 0/2] printk: Make printk() completely async Sergey Senozhatsky
2016-03-21 17:25 ` [RFC][PATCH v6 1/2] " Sergey Senozhatsky
2016-03-22 13:11 ` Petr Mladek
2016-03-22 14:04 ` Petr Mladek
2016-03-23 0:37 ` Sergey Senozhatsky
2016-03-23 8:42 ` Sergey Senozhatsky
2016-03-23 10:04 ` Petr Mladek
2016-03-24 2:24 ` Sergey Senozhatsky [this message]
2016-03-22 16:36 ` Petr Mladek
2016-03-23 1:24 ` Sergey Senozhatsky
2016-03-23 9:25 ` Petr Mladek
2016-03-23 13:20 ` Jan Kara
2016-03-23 14:30 ` Sergey Senozhatsky
2016-03-23 14:41 ` Jan Kara
2016-03-21 17:25 ` [RFC][PATCH v6 2/2] printk: Make wake_up_klogd_work_func() async Sergey Senozhatsky
2016-03-22 6:49 ` [RFC][PATCH v6 0/2] printk: Make printk() completely async Jan Kara
2016-03-22 7:57 ` Sergey Senozhatsky
2016-03-22 8:15 ` Jan Kara
2016-04-23 19:40 ` Pavel Machek
2016-04-24 5:14 ` Sergey Senozhatsky
2016-04-24 13:35 ` Pavel Machek
2016-04-24 15:00 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324022435.GA25607@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=byungchul.park@lge.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.