Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Am 23.03.2016 um 21:11 hat Max Reitz geschrieben:
> On 18.03.2016 11:31, Kevin Wolf wrote:
> > The call in hmp_drive_del() is dead code because blk_remove_bs() is
> > called a few lines above.
> 
> Ah, so that's why I didn't have it in v3. Thanks for solving that
> mystery for me. :-)

I could have mentioned it in the review, but I figured it was quicker to
just send a follow-up patch.

> >                           The only other remaining user is
> > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the
> > named nodes list. This path inlines the list entry removal into
> > bdrv_delete() and removes bdrv_make_anon().
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  block.c               | 15 +++------------
> >  blockdev.c            |  3 ---
> >  include/block/block.h |  1 -
> >  3 files changed, 3 insertions(+), 16 deletions(-)
> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>

Thanks.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]