From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: syscon: include errno.h from header
Date: Thu, 24 Mar 2016 11:05:09 +0000 [thread overview]
Message-ID: <20160324110509.GA3496@x1> (raw)
In-Reply-To: <1458729422-3136412-1-git-send-email-arnd@arndb.de>
On Wed, 23 Mar 2016, Arnd Bergmann wrote:
> The syscon header uses the ENOTSUPP error constant, but doesn't
> include the header that defines it. This causes a build error
> after the imx pinctrl driver started using syscon:
>
> include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap':
> include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function)
> return ERR_PTR(-ENOTSUPP);
> ^~~~~~~~
>
> This adds the missing #include.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
> ---
> include/linux/mfd/syscon.h | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 1088149be0c9..40a76b97b7ab 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -16,6 +16,7 @@
> #define __LINUX_MFD_SYSCON_H__
>
> #include <linux/err.h>
> +#include <linux/errno.h>
>
> struct device_node;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-03-24 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 10:36 [PATCH] mfd: syscon: include errno.h from header Arnd Bergmann
2016-03-24 11:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324110509.GA3496@x1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.