From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 3/3] tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount Date: Thu, 24 Mar 2016 15:24:03 +0200 Message-ID: <20160324132403.GC8452@intel.com> References: <1458719734-13752-1-git-send-email-christophe-h.ricard@st.com> <1458719734-13752-4-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1458719734-13752-4-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Mar 23, 2016 at 08:55:34AM +0100, Christophe Ricard wrote: > We can get rid of tpm_reg variable in get_burstcount. > > Signed-off-by: Christophe Ricard Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c > index 944d279..9e91ca7 100644 > --- a/drivers/char/tpm/st33zp24/st33zp24.c > +++ b/drivers/char/tpm/st33zp24/st33zp24.c > @@ -208,21 +208,21 @@ static int get_burstcount(struct tpm_chip *chip) > { > unsigned long stop; > int burstcnt, status; > - u8 tpm_reg, temp; > + u8 temp; > struct st33zp24_dev *tpm_dev; > > tpm_dev = (struct st33zp24_dev *)TPM_VPRIV(chip); > > stop = jiffies + chip->vendor.timeout_d; > do { > - tpm_reg = TPM_STS + 1; > - status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1); > + status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 1, > + &temp, 1); > if (status < 0) > return -EBUSY; > > - tpm_reg = TPM_STS + 2; > burstcnt = temp; > - status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1); > + status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 2, > + &temp, 1); > if (status < 0) > return -EBUSY; > > -- > 2.5.0 > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140