From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Mahoney <jeffm@jeffm.io>
Cc: Roman Lebedev <lebedev.ri@gmail.com>,
David Howells <dhowells@redhat.com>,
linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs
Date: Thu, 24 Mar 2016 15:25:47 +0000 [thread overview]
Message-ID: <20160324152547.GJ17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160324152043.GA22781@ZenIV.linux.org.uk>
On Thu, Mar 24, 2016 at 03:20:43PM +0000, Al Viro wrote:
> > ocfs2_prepare_inode_for_write uses file->f_path.dentry for
> > should_remove_suid (due to needing to do it early since cluster locking
> > is unknown in setattr, according to the commit). Having
> > should_remove_suid operate on an inode would solve that easily.
>
> Can't do - there are filesystems that _need_ dentry for ->setattr().
Grr... Sorry, misread what you'd written. should_remove_suid()
ought to be switched to inode, indeed.
next prev parent reply other threads:[~2016-03-24 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 19:57 kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs Roman Lebedev
2015-09-30 19:57 ` Roman Lebedev
2015-09-30 19:57 ` [RFC PATCH] fstests: generic: Test that fsync works on file in overlayfs merged directory Roman Lebedev
2015-09-30 21:56 ` Dave Chinner
2015-09-30 22:07 ` Eric Sandeen
2015-11-06 2:57 ` kernel BUG when fsync'ing file in a overlayfs merged dir, located on btrfs Jeff Mahoney
2015-11-06 3:18 ` Al Viro
2015-11-06 4:03 ` Jeff Mahoney
2015-11-06 14:46 ` Jeff Mahoney
2016-03-24 15:20 ` Al Viro
2016-03-24 15:25 ` Al Viro [this message]
2016-03-24 15:31 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324152547.GJ17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=jeffm@jeffm.io \
--cc=lebedev.ri@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.