All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
	sabiya kazi <sabiyafk@gmail.com>
Subject: Re: Interested to participate in Outreachy Program
Date: Thu, 24 Mar 2016 22:29:36 +0000	[thread overview]
Message-ID: <20160324222936.GI14940@citrix.com> (raw)
In-Reply-To: <56F2E906.2060803@cardoe.com>

On Wed, Mar 23, 2016 at 02:05:42PM -0500, Doug Goldstein wrote:
[...]
> >  
> >      domid = find_domain(argv[optind]);
> >      if (!type)
> > -        libxl_primary_console_exec(ctx, domid);
> > -    else
> > -        libxl_console_exec(ctx, domid, num, type);
> > +        libxl_primary_console_exec(ctx, domid, escapechar);
> > +    else 
> > +        libxl_console_exec(ctx, domid, num, type, escapechar); 
> > +

Urgh... Handling API backward compatibility is really too much for a
small contribution. I'm really sorry for not having noticed this touches
stable API when I suggested this project.

I would be quite happy if you only modify tools/console/client/main.c
and teach it -t option and leave xl command and libxl API to me (or
other aspired people who wants to work on this). In the context of
Doug's project I think you have more important stuff to do.

Doug has the final say on what kind of contribution is appropriate, of
course.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-03-24 22:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 18:29 Interested to participate in Outreachy Program sabiya kazi
2016-03-11 16:59 ` sabiya kazi
2016-03-15 13:44 ` Doug Goldstein
     [not found]   ` <CAGxmxE0rqnJzW6xUEVQDvxxP+u9ZY9dpVZhNoJD1tcTRAWkWYA@mail.gmail.com>
     [not found]     ` <56EA3513.2060700@cardoe.com>
     [not found]       ` <56EAB99C.5030901@cardoe.com>
     [not found]         ` <CAGxmxE14GH6hBGWJJhug5gmQs=s9t=68P1tqhjSOeJTacU6M2g@mail.gmail.com>
     [not found]           ` <CAGxmxE2y815wVHR10FjSM175kgWRHDD+Hws_5q9==azpjxc9Bg@mail.gmail.com>
     [not found]             ` <CAGxmxE1cxGc6PY3ZWRPfOfamBH6UyyUmLVO3iDSAkeMi_RLWPQ@mail.gmail.com>
     [not found]               ` <CAGxmxE0wVfii1K61NXYdLK+d0wiYrobya+jOf-VX=Xzo3AfYog@mail.gmail.com>
2016-03-20 19:10                 ` sabiya kazi
2016-03-21 12:12                   ` sabiya kazi
2016-03-22 15:49                     ` Doug Goldstein
     [not found]                       ` <CAGxmxE0Ocq0WU4RGYj=_00y1vt_nXg9g9LwFZMd=CxF6DvDHDA@mail.gmail.com>
2016-03-23 16:34                         ` sabiya kazi
2016-03-23 18:40                           ` Doug Goldstein
2016-03-23 19:05                           ` Doug Goldstein
2016-03-24 22:29                             ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160324222936.GI14940@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=sabiyafk@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.