All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/5] netfilter: x_tables: add and use xt_check_entry_target
Date: Fri, 25 Mar 2016 15:27:49 +0100	[thread overview]
Message-ID: <20160325142749.GA1306@salvia> (raw)
In-Reply-To: <20160325114553.GA9738@breakpoint.cc>

On Fri, Mar 25, 2016 at 12:45:53PM +0100, Florian Westphal wrote:
> Florian Westphal <fw@strlen.de> wrote:
> > +	if (strcmp(t->u.user.name, XT_STANDARD_TARGET) == 0 &&
> > +	    target_offset + sizeof(struct xt_standard_target) > next_offset)
> > +		return -EINVAL;
> 
> The last hunk broke CONFIG_COMPAT, it calls into check_entry() and
> casts compat_Xt_entry to Xt_entry, but for compat case
> xt_standard_target is larger than what a 32bit userspace sends us.
> 
> For now I'd suggest to not pass this to stable, I'll  rework
> the compat handlers next week to fix this properly.

OK, I'll pull this out from the nf tree and rebase.

  reply	other threads:[~2016-03-25 14:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 17:02 [PATCH nf v3] netfilter: x_tables: perform more sanity tests on rule set Florian Westphal
2016-03-22 17:02 ` [PATCH 1/5] netfilter: x_tables: validate e->target_offset early Florian Westphal
2016-03-24 20:17   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 2/5] netfilter: x_tables: make sure e->next_offset covers remaining blob size Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 3/5] netfilter: x_tables: add and use xt_check_entry_target Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-25 11:45   ` Florian Westphal
2016-03-25 14:27     ` Pablo Neira Ayuso [this message]
2016-03-22 17:02 ` [PATCH 4/5] netfilter: x_tables: fix unconditional helper Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 5/5] netfilter: x_tables: don't move to non-existant next rule Florian Westphal
2016-03-22 17:22   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160325142749.GA1306@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.