From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 25 Mar 2016 20:09:15 +0000 Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code Message-Id: <20160325200915.GG30221@mwanda> List-Id: References: <20160317103912.GB3100@mwanda> <56F4FC08.6090009@samsung.com> In-Reply-To: <56F4FC08.6090009@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Inki Dae Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote: > Hi Dan, > > 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글: > > We know "ret" is zero and the test makes static checkers complain so > > let's delete this printk. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > index 890c9b1..12db353 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable) > > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > > - if (ret) > > - DRM_ERROR("mic: Failed to read system register\n"); > > I think we missed to keep return value from regmap_write function, > ret = regmap_write(mic->sysreg, ....); > if (ret) > ... Yeah. You're right. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code Date: Fri, 25 Mar 2016 23:09:15 +0300 Message-ID: <20160325200915.GG30221@mwanda> References: <20160317103912.GB3100@mwanda> <56F4FC08.6090009@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <56F4FC08.6090009@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim List-Id: linux-samsung-soc@vger.kernel.org T24gRnJpLCBNYXIgMjUsIDIwMTYgYXQgMDU6NTE6MjBQTSArMDkwMCwgSW5raSBEYWUgd3JvdGU6 Cj4gSGkgRGFuLAo+IAo+IDIwMTbrhYQgMDPsm5QgMTfsnbwgMTk6Mznsl5AgRGFuIENhcnBlbnRl ciDsnbQo6rCAKSDsk7Qg6riAOgo+ID4gV2Uga25vdyAicmV0IiBpcyB6ZXJvIGFuZCB0aGUgdGVz dCBtYWtlcyBzdGF0aWMgY2hlY2tlcnMgY29tcGxhaW4gc28KPiA+IGxldCdzIGRlbGV0ZSB0aGlz IHByaW50ay4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBl bnRlckBvcmFjbGUuY29tPgo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9leHlub3NfZHJtX21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJt X21pYy5jCj4gPiBpbmRleCA4OTBjOWIxLi4xMmRiMzUzIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX21pYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcm1fbWljLmMKPiA+IEBAIC0xMzAsOCArMTMwLDYgQEAgc3RhdGlj IHZvaWQgbWljX3NldF9wYXRoKHN0cnVjdCBleHlub3NfbWljICptaWMsIGJvb2wgZW5hYmxlKQo+ ID4gIAkJdmFsICY9IH4oTUlDMF9SR0JfTVVYIHwgTUlDMF9JODBfTVVYIHwgTUlDMF9PTl9NVVgp Owo+ID4gIAo+ID4gIAlyZWdtYXBfd3JpdGUobWljLT5zeXNyZWcsIERTRF9DRkdfTVVYLCB2YWwp Owo+ID4gLQlpZiAocmV0KQo+ID4gLQkJRFJNX0VSUk9SKCJtaWM6IEZhaWxlZCB0byByZWFkIHN5 c3RlbSByZWdpc3RlclxuIik7Cj4gCj4gSSB0aGluayB3ZSBtaXNzZWQgdG8ga2VlcCByZXR1cm4g dmFsdWUgZnJvbSByZWdtYXBfd3JpdGUgZnVuY3Rpb24sCj4gCXJldCA9IHJlZ21hcF93cml0ZSht aWMtPnN5c3JlZywgLi4uLik7Cj4gCWlmIChyZXQpCj4gCQkuLi4KClllYWguICBZb3UncmUgcmln aHQuCgpyZWdhcmRzLApkYW4gY2FycGVudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288AbcCYUJ0 (ORCPT ); Fri, 25 Mar 2016 16:09:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25995 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbcCYUJZ (ORCPT ); Fri, 25 Mar 2016 16:09:25 -0400 Date: Fri, 25 Mar 2016 23:09:15 +0300 From: Dan Carpenter To: Inki Dae Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code Message-ID: <20160325200915.GG30221@mwanda> References: <20160317103912.GB3100@mwanda> <56F4FC08.6090009@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56F4FC08.6090009@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote: > Hi Dan, > > 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글: > > We know "ret" is zero and the test makes static checkers complain so > > let's delete this printk. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > index 890c9b1..12db353 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable) > > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX); > > > > regmap_write(mic->sysreg, DSD_CFG_MUX, val); > > - if (ret) > > - DRM_ERROR("mic: Failed to read system register\n"); > > I think we missed to keep return value from regmap_write function, > ret = regmap_write(mic->sysreg, ....); > if (ret) > ... Yeah. You're right. regards, dan carpenter