From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbcCZQGt (ORCPT ); Sat, 26 Mar 2016 12:06:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49200 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbcCZQGq (ORCPT ); Sat, 26 Mar 2016 12:06:46 -0400 Date: Sat, 26 Mar 2016 17:06:38 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Andi Kleen Subject: Re: [PATCH 1/6] perf mem: Add --ldlat option Message-ID: <20160326160638.GA27964@krava.redhat.com> References: <1458823940-24583-1-git-send-email-jolsa@kernel.org> <1458823940-24583-2-git-send-email-jolsa@kernel.org> <20160324155758.GA32162@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160324155758.GA32162@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 26 Mar 2016 16:06:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2016 at 12:57:58PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 24, 2016 at 01:52:15PM +0100, Jiri Olsa escreveu: > > Adding --ldlat option to specify desired latency > > for loads event. > > > > Specify 50 as loads event latency: > > > > $ perf mem record -e ldlat-loads -v --ldlat 50 true > > calling: record -W -d -e cpu/mem-loads,ldlat=50/P true > > We have all this infrastructure to set per-event settings, on the > command line, and here we end up adding a separate command line option > to do that? Why not something like: > > perf mem record -e ldlat-loads/lat=50/ true will check ;-) thanks, jirka