From: Stephen Hemminger <stephen@networkplumber.org>
To: "Varlese, Marco" <marco.varlese@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Jiri Pirko <jiri@resnulli.us>,
John Fastabend <john.fastabend@gmail.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"Szczerbik, PrzemyslawX" <przemyslawx.szczerbik@intel.com>
Subject: Re: [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() error messages
Date: Sun, 27 Mar 2016 11:02:15 -0700 [thread overview]
Message-ID: <20160327110215.44f62214@xeon-e3> (raw)
In-Reply-To: <C4896FB061E7DE4AAC93031BDCA044B11A2146FF@IRSMSX108.ger.corp.intel.com>
On Tue, 22 Mar 2016 13:02:02 +0000
"Varlese, Marco" <marco.varlese@intel.com> wrote:
> An attempt to add invalid address to interface would print "???" string
> instead of the address family name.
>
> For example:
> $ ip address add 256.10.166.1/24 dev ens8
> Error: ??? prefix is expected rather than "256.10.166.1/24".
>
> $ ip neighbor add proxy 2001:db8::g dev ens8
> Error: ??? address is expected rather than "2001:db8::g".
>
> With this patch the output will look like:
> $ ip address add 256.10.166.1/24 dev ens8
> Error: inet prefix is expected rather than "256.10.166.1/24".
>
> $ ip neighbor add proxy 2001:db8::g dev ens8
> Error: inet6 address is expected rather than "2001:db8::g".
>
> Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
> Signed-off-by: Marco Varlese <marco.varlese@intel.com>
Since this was so trivial, I did change manually since patch was corrupted.
next prev parent reply other threads:[~2016-03-27 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 13:02 [PATCH iproute2 v1 1/1] lib/utils: fix get_addr() and get_prefix() error messages Varlese, Marco
2016-03-27 17:35 ` Stephen Hemminger
2016-03-30 7:19 ` Varlese, Marco
2016-03-27 18:02 ` Stephen Hemminger [this message]
2016-03-30 23:54 ` Stephen Hemminger
2016-03-31 8:04 ` Varlese, Marco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160327110215.44f62214@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=marco.varlese@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslawx.szczerbik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.