From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akMWJ-0004k8-O8 for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:03:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akMWG-0006Ml-Hb for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:03:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akMWG-0006Mh-C1 for qemu-devel@nongnu.org; Sun, 27 Mar 2016 22:03:04 -0400 Date: Mon, 28 Mar 2016 10:02:57 +0800 From: Peter Xu Message-ID: <20160328020257.GH28183@pxdev.xzpeter.org> References: <1458872009-13342-1-git-send-email-jasowang@redhat.com> <1458872009-13342-3-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1458872009-13342-3-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 2/8] intel_iommu: name vtd address space with devfn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Eduardo Habkost , mst@redhat.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, pbonzini@redhat.com, Richard Henderson On Fri, Mar 25, 2016 at 10:13:23AM +0800, Jason Wang wrote: > To avoid duplicated name and ease debugging. > > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Signed-off-by: Jason Wang > --- > hw/i386/intel_iommu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 347718f..d647b42 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -1901,6 +1901,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) > uintptr_t key = (uintptr_t)bus; > VTDBus *vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key); > VTDAddressSpace *vtd_dev_as; > + char name[128]; > > if (!vtd_bus) { > /* No corresponding free() */ > @@ -1913,6 +1914,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) > vtd_dev_as = vtd_bus->dev_as[devfn]; > > if (!vtd_dev_as) { > + sprintf(name, "intel_iommu_devfn_%d", devfn); It's safe here, but would snprintf() look better? > vtd_bus->dev_as[devfn] = vtd_dev_as = g_malloc0(sizeof(VTDAddressSpace)); > > vtd_dev_as->bus = bus; > @@ -1920,9 +1922,9 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s, PCIBus *bus, int devfn) > vtd_dev_as->iommu_state = s; > vtd_dev_as->context_cache_entry.context_cache_gen = 0; > memory_region_init_iommu(&vtd_dev_as->iommu, OBJECT(s), > - &s->iommu_ops, "intel_iommu", UINT64_MAX); > + &s->iommu_ops, name, UINT64_MAX); > address_space_init(&vtd_dev_as->as, > - &vtd_dev_as->iommu, "intel_iommu"); > + &vtd_dev_as->iommu, name); > } > return vtd_dev_as; > } > -- > 2.5.0 > Besides the nit-pick: Acked-by: Peter Xu