From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libxslt: fix static build
Date: Tue, 29 Mar 2016 03:01:13 +0200 [thread overview]
Message-ID: <20160329030113.55474130@free-electrons.com> (raw)
In-Reply-To: <1459199363-28640-1-git-send-email-joerg.krause@embedded.rocks>
Hello,
On Mon, 28 Mar 2016 23:09:23 +0200, J?rg Krause wrote:
> Set --with-libxml-libs-prefix so libtool finds the correct dependencies for
> libxml2.
>
> Fixes:
> http://autobuild.buildroot.net/results/3f8/3f8d876ed6cfe6e73a75fa8904ebdd3f6f0fe53c/
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> package/libxslt/libxslt.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/libxslt/libxslt.mk b/package/libxslt/libxslt.mk
> index 2e5cc14..0cc4bb9 100644
> --- a/package/libxslt/libxslt.mk
> +++ b/package/libxslt/libxslt.mk
> @@ -14,7 +14,8 @@ LIBXSLT_CONF_OPTS = \
> --with-gnu-ld \
> --without-debug \
> --without-python \
> - --with-libxml-prefix=$(STAGING_DIR)/usr/
> + --with-libxml-prefix=$(STAGING_DIR)/usr/ \
> + --with-libxml-libs-prefix=$(STAGING_DIR)/usr/lib
I've applied because it indeed works, but to be honest, I don't
understand why: I don't quite understand how this can fix the build.
All what this option does is:
AC_ARG_WITH(libxml-libs-prefix,
[ --with-libxml-libs-prefix=[PFX] Specify location of libxml libs],
LIBXML_LIBS="-L$withval"
)
I.e, it will add -L$(STAGING_DIR)/usr/lib to the gcc options. But that
is completely useless because $(STAGING_DIR)/usr/lib is already the
default search path for libraries. So why does it fix the build? I
don't know.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-29 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 21:09 [Buildroot] [PATCH] package/libxslt: fix static build Jörg Krause
2016-03-29 1:01 ` Thomas Petazzoni [this message]
2016-03-29 12:52 ` Thomas Petazzoni
2016-03-29 13:52 ` Jörg Krause
2016-03-29 14:09 ` Thomas Petazzoni
2016-03-29 17:44 ` Baruch Siach
2016-03-29 17:56 ` Thomas Petazzoni
2016-03-29 18:35 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329030113.55474130@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.