From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't hand out pNFS layouts for reflink inodes
Date: Tue, 29 Mar 2016 09:21:28 +0200 [thread overview]
Message-ID: <20160329072128.GA14940@lst.de> (raw)
In-Reply-To: <20160328195140.GB5360@birch.djwong.org>
On Mon, Mar 28, 2016 at 12:51:40PM -0700, Darrick J. Wong wrote:
> > /*
> > + * The pNFS block layout spec actually supports reflink like
> > + * functionality, but the Linux pNFS server doesn't implement it yet.
> > + */
> > + if (!xfs_is_reflink_inode(ip))
> > + return -ENXIO;
>
> /me isn't familiar with pNFS, but doesn't this make it so that
> xfs_fs_map_blocks /only/ works on reflinked files? Maybe I'm misreading the
> comment, but it sounds to me like Linux doesn't support reflinked files over
> pNFS and therefore we want to disable this iomapping functionality any time we
> find a reflinked file.
>
> But maybe there's a subtlety here that I'm missing?
You jsut missed me fat fingering the check :)
Btw, we'll need something similar to prevent swapfiles which just use
->bmap, but unfortunately swap just checks for the existences of method,
so I'll probably have to do some VFS changes to properly support that.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-29 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 16:34 [PATCH] xfs: don't hand out pNFS layouts for reflink inodes Christoph Hellwig
2016-03-28 19:51 ` Darrick J. Wong
2016-03-29 7:21 ` Christoph Hellwig [this message]
2016-03-30 0:08 ` Darrick J. Wong
2016-03-30 17:26 ` Christoph Hellwig
2016-03-30 17:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329072128.GA14940@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.