From: hch@infradead.org (Christoph Hellwig)
Subject: nvme device timeout
Date: Tue, 29 Mar 2016 04:06:59 -0700 [thread overview]
Message-ID: <20160329110659.GA10015@infradead.org> (raw)
In-Reply-To: <36E8D38D6B771A4BBDB1C0D800158A51865EFB85@SSIEXCH-MB3.ssi.samsung.com>
On Tue, Mar 29, 2016@11:04:51AM +0000, Judy Brock-SSI wrote:
> I think controllers that need it won't know they need it (like Keith hypothesized, will have an unknowing reliance on polling for completions during probe) and so a quirk flag won't do a lot of good.
> Seems like it makes sense to put it back in to avoid breaking HW that do need it if there is not a compelling functional reason not to do so. Since 4.6 is still in RC stage, maybe it could be put back into 4.6.
It's not about not knowing - these controllers are broken plain and
simple and need to be fixed. It's the same as we do for all kinds of
USB crap in SCSI - we don't simple tolerate broken behavior but instead
require a quirk for it.
next prev parent reply other threads:[~2016-03-29 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 16:44 nvme device timeout Tim Mohlmann
2016-03-28 17:24 ` Keith Busch
2016-03-28 22:30 ` Judy Brock-SSI
2016-03-28 22:54 ` Keith Busch
2016-03-29 7:03 ` Christoph Hellwig
2016-03-29 11:04 ` Judy Brock-SSI
2016-03-29 11:06 ` Christoph Hellwig [this message]
2016-03-29 14:42 ` Matthew Wilcox
2016-03-29 16:52 ` Tim Mohlmann
[not found] <1604554248.106551459228253752.JavaMail.weblogic@epmlwas03c>
2016-03-29 14:38 ` Keith Busch
2016-03-29 17:17 ` Tim Mohlmann
2016-04-01 16:02 ` Derrick, Jonathan
2016-04-01 16:25 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329110659.GA10015@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.