From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel.vetter@intel.com" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all
Date: Tue, 29 Mar 2016 14:47:09 +0200 [thread overview]
Message-ID: <20160329144709.0ce953ec@bbrezillon> (raw)
In-Reply-To: <1459254355.3021.34.camel@synopsys.com>
On Tue, 29 Mar 2016 12:25:55 +0000
Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote:
> Hi Daniel,
>
> On Tue, 2016-03-29 at 14:21 +0200, Daniel Vetter wrote:
> > Accidentally fell through the cracks in
> >
> > commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> > Author: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > Date: Wed Mar 23 11:42:54 2016 +0300
> >
> > drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()
> >
> > despite that Boris acked that patch.
My apologies for putting my ack on something I didn't even compile test.
> >
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Cc: Alexey Brodkin <abrodkin@synopsys.com>
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > index 3d8d16402d07..8ab4318e57a1 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > @@ -615,7 +615,7 @@ err:
> > static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
> > {
> > mutex_lock(&dev->mode_config.mutex);
> > - drm_connector_unplug_all(dev);
> > + drm_connector_unregister_all(dev);
> > mutex_unlock(&dev->mode_config.mutex);
> > }
>
> Isn't done in my "[PATCH 2/3 v5] drm: atmel_hldc: Use generic drm_connector_register_all() helper"?
This is fixing v3 of your series. Apparently this problem is fixed in
v4 and v5.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-29 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 12:21 [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all Daniel Vetter
2016-03-29 12:25 ` Alexey Brodkin
2016-03-29 12:47 ` Boris Brezillon [this message]
2016-03-29 12:55 ` Daniel Vetter
2016-03-30 12:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329144709.0ce953ec@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.