From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
kan.liang@intel.com, jolsa@redhat.com, namhyung@kernel.org,
vincent.weaver@maine.edu
Subject: Re: [PATCH] perf/core: Fix time tracking bug with multiplexing
Date: Tue, 29 Mar 2016 12:43:39 -0300 [thread overview]
Message-ID: <20160329154339.GB31342@redhat.com> (raw)
In-Reply-To: <20160329072644.GB3408@twins.programming.kicks-ass.net>
Em Tue, Mar 29, 2016 at 09:26:44AM +0200, Peter Zijlstra escreveu:
> On Tue, Mar 29, 2016 at 03:33:23AM +0200, Stephane Eranian wrote:
> > This patch fixes a bug introduced by:
> >
> > commit 3cbaa59069677920186dcf502632ca1df4329f80
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date: Wed Feb 24 18:45:47 2016 +0100
> >
> > perf: Fix ctx time tracking by introducing EVENT_TIME
>
> Normal quoting style is:
>
> 3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
>
> I have the following git alias to help with that:
>
> one = show -s --pretty='format:%h (\"%s\")'
Cool, for completeness sake:
$ git config --global alias.one "show -s --pretty='format:%h (\"%s\")'"
$ git one 3cbaa59069677920186dcf502632ca1df4329f80
3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
Make sure you have this in place:
$ git config --global core.abbrev 12
I also have this, FWIW:
$ cat ~/bin/fixes
#!/bin/bash
if [ $# -eq 1 ] ; then
cset=$1
else
read cset
fi
git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g'
echo "Fixes: " `git one $cset`
$ vim ~/bin/fixes
$ fixes 3cbaa59069677920186dcf502632ca1df4329f80
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Fixes 3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
$
So that, in vim, I can select the changeset, then do: ":'<,'>!fixes", so
that the author and commiter of the fixed cset gets on the CC list.
- Arnaldo
next prev parent reply other threads:[~2016-03-29 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 1:33 [PATCH] perf/core: Fix time tracking bug with multiplexing Stephane Eranian
2016-03-29 7:26 ` Peter Zijlstra
2016-03-29 15:43 ` Arnaldo Carvalho de Melo [this message]
2016-03-29 21:23 ` Stephane Eranian
2016-03-31 9:18 ` [tip:perf/core] " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329154339.GB31342@redhat.com \
--to=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.