Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3406 bytes --]

On Tue, Mar 29, 2016 at 05:24:59PM +0200, Marcel Ziswiler wrote:
> Hi Thierry
> 
> On Fri, 2016-03-04 at 17:19 +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org
> > >
> > 
> > The NVIDIA Tegra XUSB pad controller provides a set of pads, each
> > with a
> > set of lanes that are used for PCIe, SATA and USB.
> 
> I finally got around trying this both on Jetson TK1 as well as our own
> Toradex Apalis TK1 module we are about to mainline.

Looking forward to it.

>                                                     I actually applied
> your patch set on top of 4.6.0-rc1. While USB 3.0 seems to work fine I
> noticed PCIe and SATA no more to come up right with the following
> message:
> 
> [    2.794458] tegra-pcie 1003000.pcie-controller: PLL failed to lock:
> -110
> [    2.801177] tegra-pcie 1003000.pcie-controller: failed to power on
> PHY: -110
> [    2.809031] tegra-pcie: probe of 1003000.pcie-controller failed with
> error -110
> 
> Do you happen to know what could be the issue?

That's to be expected. You'll need this one:

	http://patchwork.ozlabs.org/patch/596548/

which I had hoped would make v4.6-rc1, but didn't. I'll have to respin
and send out again. I didn't know that SATA failed in the same way, but
I'll need to recheck and see if it needs a similar change.

> As for USB I do get some message about the endpoint companion but do
> not know whether or not this is to be expected:
> 
> [ 1021.575301] usb 4-1: new SuperSpeed USB device number 2 using tegra-
> xusb
> [ 1021.598913] usb 4-1: No SuperSpeed endpoint companion for config
> 1  interface 0 altsetting 0 ep 2: using minimum values

I'm not exactly sure why that message appears, but I think it is
harmless.

> Otherwise it looks good:
> 
> ubuntu@tegra-ubuntu:~$ lsusb
> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 004 Device 002: ID 0951:1666 Kingston Technology DataTraveler G4
> Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> 
> And performs satisfactorily (up from around 24 MB/sec with just USB
> 2.0):
> 
> ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sda
> 
> /dev/sda:
>  Timing buffered disk reads:  94 MB in  3.05 seconds =  30.81 MB/sec
> 
> Apalis TK1 actually features two USB 3.0 host ports:
> 
> ubuntu@tegra-ubuntu:~$ lsusb
> Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 005 Device 002: ID 0951:1666 Kingston Technology DataTraveler G4
> Bus 005 Device 003: ID 1f75:0902 Innostor Technology Corporation IS902
> UFD controller
> Bus 005 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> Bus 004 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> 
> ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sda
> 
> /dev/sda:
>  Timing buffered disk reads:  96 MB in  3.00 seconds =  31.98 MB/sec
> 
> ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sdb
> 
> /dev/sdb:
>  Timing buffered disk reads: 152 MB in  3.04 seconds =  49.99 MB/sec

Looking great. Thanks for testing.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]