From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date: Wed, 30 Mar 2016 09:10:57 +0100 [thread overview]
Message-ID: <20160330081057.GD3323@x1> (raw)
In-Reply-To: <20160330080837.GA3323@x1>
On Wed, 30 Mar 2016, Lee Jones wrote:
> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>
> > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> > direct dependencies.
> >
> > This fixes warning on allyesconfig on ARCH=um:
> >
> > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X &&
> > DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW
> > && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
> > S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
> > RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM &&
> > ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB)
> > selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Holding off on this until the discussion reaches some kind of
> consensus.
FYI: https://lkml.org/lkml/2016/3/29/716
> > ---
> >
> > Changes since v1:
> > 1. Remove the comment why HAS_IOMEM dependency was added.
> > 2. Exdended description.
> > ---
> > drivers/phy/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 879ac798f6f7..17e5f5c7ffff 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -226,6 +226,7 @@ config PHY_MT65XX_USB3
> > config PHY_HI6220_USB
> > tristate "hi6220 USB PHY support"
> > depends on (ARCH_HISI && ARM64) || COMPILE_TEST
> > + depends on HAS_IOMEM
> > select GENERIC_PHY
> > select MFD_SYSCON
> > help
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-30 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:49 [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski
2016-03-30 8:08 ` Lee Jones
2016-03-30 8:10 ` Lee Jones [this message]
2016-03-30 8:24 ` Krzysztof Kozlowski
2016-04-07 13:23 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330081057.GD3323@x1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.